[issue-3393][slice-6/7] Per-repo test-gate + reviewer-diff scoping...

[james-in-a-box]

Scope the implement-phase gates to the slice's repo (operator rulings #3, #5). The test gate runs in the slice's repo worktree only; the reviewer diff is git diff in that worktree against that repo's base; the slice's agent runs with cwd in the slice's repo worktree under that repo's CLAUDE.md, linters, and check commands — egg's make lint/make test apply only to slices whose repo is egg. Documentation is updated to describe the shipped multi-repo model.

Base PR: #3418

What's in this PR

Commits (5):

• Persist BRC history for slice-6 (Slice PRs are missing analysis/plan docs and all BRC history; need a 'context' PR for refine+plan phases plus per-slice BRC in each slice PR #2548)
• Slice-6 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): add _resolve_slice_gate_repo accessor (converge w/ tester task-6-2)
• test(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): slice-6 per-repo gate/diff/convention scoping tests (task-6-2)
• Slice-6 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): scope test-gate/reviewer-diff/cwd to slice.repo (task-6-1)
• docs(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): document shipped multi-repo pipeline model

.egg-state/agent-outputs/coder/brc-memory-issue-3393.md |   84 ++
 .egg-state/brc-history/3393-implement-slice-6.json      | 1475 +++++++++++++++++++++++++++++++++++
 .egg-state/brc-history/3393-implement-slice-6.md        | 1423 +++++++++++++++++++++++++++++++++
 docs/architecture/slice-dag.md                          |  117 +++
 docs/guides/sdlc-pipeline.md                            |   58 ++
 orchestrator/routes/pipelines.py                        |  135 +++-
 orchestrator/tests/test_pipelines.py                    |  317 ++++++++
 7 files changed, 3603 insertions(+), 6 deletions(-)

This slice

Per-repo test-gate + reviewer-diff scoping + per-repo conventions

Files affected:

• orchestrator/routes/pipelines.py
• orchestrator/tests/test_pipelines.py
• docs/guides/sdlc-pipeline.md
• docs/architecture/slice-dag.md

Tasks (3) + acceptance criteria

• task-6-1: Scope the test gate and reviewer diff to the slice's repo. In the implement-phase gate/review wiring (orchestrator/routes/pipelines.py and any test-gate/reviewer-diff helper it calls): resolve the slice's worktree from the owner/repo-keyed map (slice 3), run the test gate in THAT worktree, compute the reviewer diff as git diff in that worktree against that repo's base branch, and resolve check/lint commands from the slice's repo conventions (its own CLAUDE.md / linters) rather than hard-coding egg's make lint/make test. Set the slice agent's cwd to the slice's repo worktree. Keep the egg-repo path (the common case) behaviorally identical to today.
  • Acceptance criteria: - The test gate runs only in the slice's repo worktree; the reviewer diff is scoped to that repo against its base. - The slice agent's cwd is the slice's repo worktree; check/lint commands resolve from that repo's conventions, not egg's, for non-egg slices. - egg-repo slices behave exactly as today (N=1 baseline unchanged).
• task-6-2: Add tests in orchestrator/tests: for a multi-repo pipeline, the test gate is invoked in the slice's repo worktree (not the primary's), the reviewer diff is computed against the slice's repo base, and check commands resolve from the slice's repo; for an egg-repo slice, behavior matches the current single-repo path. Mock worktree paths and per-repo command resolution.
  • Acceptance criteria: - Tests assert per-repo test-gate invocation, per-repo reviewer-diff base, and per-repo check-command resolution, plus the egg-repo baseline. - make test (narrowed) and make test-all green.
• task-6-3: Update documentation to describe the shipped multi-repo model (snapshot, not changelog): docs/guides/sdlc-pipeline.md (list-shaped submission with per-repo base_branch; uniform visibility + uniform auth requirement; primary repo for naming/default) and the relevant architecture doc for slices/PRs (Slice.repo 1:1 rule; per-repo work branch + context PR; cross-repo ordering via slice dependencies; the cq-1 two-tier merge-sequencing hold; per-repo gate/diff/convention scoping). Describe current behavior; do not narrate slice numbers or this pipeline's process.
  • Acceptance criteria: - The pipeline guide documents list-shaped submission, the uniformity rules, and the primary-repo concept. - An architecture doc documents Slice.repo (1:1), per-repo work-branch/context-PR, cross-repo ordering + the two-tier hold, and per-repo gate scoping — as current-state snapshot, no slice/TASK references.

Stack

• Position: slice 6 of 7 in pipeline issue-3393
• Base PR: Multi-repo pipelines: coordinated PRs across repositories (#3393) #3418
• Stacked on top of egg/issue-3393/slice-5