[issue-3393][slice-3/6] Stop the repos[0] collapse...

[james-in-a-box]

Remove all three enumerated repos[0] collapse sites and expose the full repo→worktree map to the agent environment, re-keyed by full owner/repo (operator ruling #6). Today the worktree dict keys by bare repo name (_worktree.py:74-79) and would collide on same-name repos under different owners. A ratchet test plus a grep -rn 'repos\[0\]' sweep guard against regressions, explicitly allowing the len(repos)==1-guarded sandbox/egg_lib/sdlc_hitl.py:82 (not a collapse).

Base PR: #3418

What's in this PR

Commits (6):

• Persist BRC history for slice-3 (Slice PRs are missing analysis/plan docs and all BRC history; need a 'context' PR for refine+plan phases plus per-slice BRC in each slice PR #2548)
• test(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): slice-3 positive resolution assertions for authorship + overseer repo (task-3-3 AC1)
• test(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): slice-3 converge env-map tests to EGG_PIPELINE_REPOS (task-3-3)
• test(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): slice-3 repos[0]-collapse ratchet + owner/repo env-map tests (task-3-3)
• Coder BRC memory: slice-3 assessment (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393)
• Slice-3 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): kill repos[0] collapse; owner/repo-keyed worktree map

.egg-state/agent-outputs/coder/brc-memory-issue-3393.md |   64 +
 .egg-state/brc-history/3393-implement-slice-3.json      | 2740 +++++++++++++++++++++++++++++++
 .egg-state/brc-history/3393-implement-slice-3.md        | 3048 +++++++++++++++++++++++++++++++++++
 gateway/gateway.py                                      |   12 +-
 orchestrator/commit_authorship_store.py                 |   27 +-
 orchestrator/gateway_client/_models.py                  |    5 +-
 orchestrator/gateway_client/_worktree.py                |    9 +-
 orchestrator/kubernetes_spawner/_spawn.py               |   41 +-
 orchestrator/routes/pipelines.py                        |   34 +-
 orchestrator/tests/test_commit_authorship_store.py      |   95 ++
 orchestrator/tests/test_gateway_client.py               |   30 +
 orchestrator/tests/test_kubernetes_spawner.py           |  245 +++
 orchestrator/tests/test_overseer_repo_resolution.py     |  110 ++
 13 files changed, 6435 insertions(+), 25 deletions(-)

This slice

Stop the repos[0] collapse; owner/repo-keyed worktree map in agent env

Files affected:

• orchestrator/kubernetes_spawner/_spawn.py
• orchestrator/commit_authorship_store.py
• orchestrator/routes/pipelines.py
• orchestrator/gateway_client/_worktree.py
• gateway/gateway.py
• orchestrator/tests/test_kubernetes_spawner.py
• orchestrator/tests/test_gateway_client.py

Tasks (3) + acceptance criteria

• task-3-1: Remove the three collapse sites and thread the full repo set through. (a) orchestrator/kubernetes_spawner/_spawn.py:452 (repo_name = repos[0].split("/")[-1]) and :464 (pipeline_repo = repos[0]) plus the EGG_PIPELINE_REPO export at :523 — replace with logic that derives naming from the pipeline's primary repo but exposes the FULL repo→worktree map to the agent env keyed by full owner/repo (feeding from the client worktrees field → spawner repo_volumes). Keep EGG_PIPELINE_REPO populated with the primary for back-compat but add the full map (e.g. an EGG_PIPELINE_REPOS / repo_volumes env exposure) so agents can select the slice's repo. (b) orchestrator/commit_authorship_store.py:932-933 — replace the repos[0] fallback with primary-repo resolution that does not assume a single repo. (c) orchestrator/routes/pipelines.py:732 (overseer_repo = pipeline_repos[0]) — resolve via the primary accessor. Use the primary_repo accessor from slice 1 rather than re-introducing index-0 access.
  • Acceptance criteria: - All three collapse sites (_spawn.py:452/:464, commit_authorship_store.py:932-933, pipelines.py:732) no longer index repos[0]; they use the primary accessor or the full map. - The agent environment exposes the full repo→worktree map keyed by full owner/repo (no bare-name collision). - EGG_PIPELINE_REPO still resolves to the primary for back-compat.
• task-3-2: Re-key the worktree map by full owner/repo at its source. In orchestrator/gateway_client/_worktree.py:74-79 the worktrees dict is keyed by bare repo name (repo.split("/")[-1]-shaped); change the key to the full owner/repo so two repos with the same short name under different owners no longer collide, and update the corresponding gateway handler keying in gateway/gateway.py (worktree creation response, ~7827) to match. Preserve the returned path values; only the key changes. Update the spawner consumer (fed via repo_volumes) to read the owner/repo keys.
  • Acceptance criteria: - WorktreeResult.worktrees (and the gateway handler that builds it) is keyed by full owner/repo. - Same-name-different-owner repos get distinct entries. - The spawner reads the owner/repo-keyed map; paths are unchanged.
• task-3-3: Add tests + a regression ratchet in orchestrator/tests. Assert: the agent env exposes the full owner/repo-keyed repo→path map; each of the three former collapse sites now resolves via the primary accessor / full map (unit-level assertions on the spawner env, commit-authorship resolution, and overseer-repo resolution for a 2-repo pipeline); and a ratchet test that greps the orchestrator source for repos[0] collapse patterns and fails if any reappear, with an explicit allowlist entry for the len(repos)==1-guarded sandbox/egg_lib/sdlc_hitl.py:82. Also assert the worktree map keying is owner/repo (no bare-name collision) via test_kubernetes_spawner / test_gateway_client.
  • Acceptance criteria: - Tests assert the full owner/repo-keyed env map and correct resolution at all three former collapse sites for a multi-repo pipeline. - A ratchet test fails if a repos[0] collapse is reintroduced, with sdlc_hitl.py:82 allowlisted. - make test (narrowed) and make test-all green.

Stack

• Position: slice 3 of 6 in pipeline issue-3393
• Base PR: Multi-repo pipelines: coordinated PRs across repositories (#3393) #3418
• Stacked on top of egg/issue-3393/slice-2