[issue-3393][slice-2/6] List-shaped submission + uniform...

[james-in-a-box]

Make submission genuinely list-shaped end to end and enforce the two uniformity rules. submit_task and POST /api/v1/pipelines accept a list of {repo, base_branch}; a bare single repo stays accepted (back-compat). Submission-time validation rejects mixed-visibility sets and mixed-auth-mode sets with actionable errors (reusing get_repo_visibility and per-repo get_auth_mode). Same-name repo sets are NOT rejected (operator ruling #6). One repo is designated primary (first unless flagged) for naming and slice-default.

Base PR: #3418

What's in this PR

Commits (6):

• Persist BRC history for slice-2 (Slice PRs are missing analysis/plan docs and all BRC history; need a 'context' PR for refine+plan phases plus per-slice BRC in each slice PR #2548)
• Slice-2 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): fail closed on indeterminate visibility (reviewer_security v1)
• Slice-2 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): add gateway-side uniformity helpers (converge with tester task-2-3)
• Coder BRC memory: slice-2 assessment (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393)
• Slice-2 (Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): list-shaped submission + uniform visibility/auth validation
• test(Feature: multi-repo pipelines — coordinated PRs across repositories in one pipeline #3393): slice-2 submission + uniformity tests (task-2-3)

.egg-state/agent-outputs/coder/brc-memory-issue-3393.md |   83 +
 .egg-state/brc-history/3393-implement-slice-2.json      | 2686 ++++++++++++++++++++++++++++++++
 .egg-state/brc-history/3393-implement-slice-2.md        | 2857 +++++++++++++++++++++++++++++++++++
 config/repo_config.py                                   |   33 +
 gateway/repo_visibility.py                              |   84 +
 gateway/tests/test_repo_visibility.py                   |  150 ++
 orchestrator/mcp_tools/_submit.py                       |   58 +-
 orchestrator/mcp_tools/_tool_defs.py                    |   38 +-
 orchestrator/routes/pipelines.py                        |  204 +++
 orchestrator/state_store/_crud.py                       |   20 +-
 orchestrator/tests/test_pipelines.py                    |  263 ++++
 11 files changed, 6470 insertions(+), 6 deletions(-)

This slice

List-shaped submission + uniform visibility/auth validation

Files affected:

• orchestrator/mcp_tools/_submit.py
• orchestrator/routes/pipelines.py
• gateway/repo_visibility.py
• gateway/git_client/_credentials.py
• orchestrator/tests/test_pipelines.py
• gateway/tests/test_repo_visibility.py

Tasks (3) + acceptance criteria

• task-2-1: Extend the submission surface to accept a repo list. In orchestrator/mcp_tools/_submit.py (submit_task, currently a single repo + base_branch at :78-79): accept either a single repo/base_branch (back-compat) or a list of {repo, base_branch} entries; normalize to the list-shaped Pipeline repo set from slice 1 with the first entry (or an explicitly flagged one) as primary. In orchestrator/routes/pipelines.py: thread the repo list through the POST /api/v1/pipelines handler and pipeline construction so the full list reaches Pipeline; do not collapse to a single repo. Do not add the uniformity validators here (TASK-2-2) and do not touch the three collapse sites (slice 3).
  • Acceptance criteria: - submit_task accepts a list of {repo, base_branch}; a bare single repo still works unchanged. - The pipelines route constructs a Pipeline with the full repo list (per-repo base_branch), primary = first/flagged. - No collapse to repos[0] is introduced in the submission path.
• task-2-2: Add submission-time uniformity validation. Reuse gateway/repo_visibility.py get_repo_visibility(owner, repo) to require all repos in a run to be uniformly private or uniformly public, and gateway/git_client/_credentials.py get_auth_mode(repo) to require a single uniform auth mode across the run. On a mixed set, reject the submission with an actionable error naming the offending repos and which dimension (visibility vs auth) diverged. Do NOT reject same-name repo sets — the collision is resolved by the owner/repo re-key in slice 3 (operator ruling Phase 4: CLI implementation #6). Add small, focused helper functions (e.g. assert_uniform_visibility, assert_uniform_auth) on the gateway modules where the per-repo lookups live, and call them from the submission path in orchestrator/routes/pipelines.py.
  • Acceptance criteria: - A mixed-visibility repo set is rejected with an actionable, repo-naming error. - A mixed-auth-mode repo set is rejected with an actionable error. - Same-name repo sets are NOT rejected. - Uniform sets pass; single-repo submissions are trivially uniform.
• task-2-3: Add tests for slice 2 in orchestrator/tests (submission) and gateway/tests (uniformity helpers): list submission accepted and constructs the full repo list; bare single-repo submission still accepted; mixed-visibility set rejected with the expected error; mixed-auth-mode set rejected; same-name-different-owner set NOT rejected; primary-repo defaulting to first/flagged. Include the N=1 regression path.
  • Acceptance criteria: - Tests cover list + single-repo submission, both uniformity rejections, the same-name-allowed case, and primary defaulting. - N=1 submission behavior is asserted unchanged. - make test (narrowed) and make test-all green.

Stack

• Position: slice 2 of 6 in pipeline issue-3393
• Base PR: Multi-repo pipelines: coordinated PRs across repositories (#3393) #3418
• Stacked on top of egg/issue-3393/slice-1