Skip to content

Treat cancelled check conclusions as non-failures #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 2 commits into from
Feb 8, 2026
Merged

Treat cancelled check conclusions as non-failures #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a68d79f
Treat cancelled check conclusions as non-failures
Feb 8, 2026
ba52783
Apply cancelled check fix to reusable-review.yml for consistency
james-in-a-box[bot] Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/reusable-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,14 @@ jobs:
no_checks_count=0

completed=$(echo "$checks" | jq '[.[] | select(.status == "completed")] | length')
failed=$(echo "$checks" | jq '[.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral")] | length')
failed=$(echo "$checks" | jq '[.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral" and .conclusion != "cancelled")] | length')

echo "Checks: ${completed}/${total} completed, ${failed} failed"

if [[ "$completed" -eq "$total" ]]; then
if [[ "$failed" -gt 0 ]]; then
echo "::warning::${failed} check(s) failed — skipping review"
echo "$checks" | jq -r '.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral") | " FAILED: \(.name) (\(.conclusion))"'
echo "$checks" | jq -r '.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral" and .conclusion != "cancelled") | " FAILED: \(.name) (\(.conclusion))"'
echo "passed=false" >> "$GITHUB_OUTPUT"
else
echo "All ${total} checks passed"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sdlc-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ jobs:

total=$(echo "$external_checks" | jq 'length')
completed=$(echo "$external_checks" | jq '[.[] | select(.status == "completed")] | length')
failed=$(echo "$external_checks" | jq '[.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral")] | length')
failed=$(echo "$external_checks" | jq '[.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral" and .conclusion != "cancelled")] | length')
pending=$(echo "$external_checks" | jq -r '[.[] | select(.status != "completed")] | map(.name) | join(", ")')

echo "Checks: ${completed}/${total} completed, ${failed} failed (elapsed: ${elapsed}s)"
Expand Down Expand Up @@ -618,7 +618,7 @@ jobs:
# All checks completed but some failed — keep waiting, autofix may push a new commit
if [[ "$completed" -eq "$total" && "$failed" -gt 0 ]]; then
echo "Checks completed with ${failed} failure(s) — waiting for autofix..."
echo "$external_checks" | jq -r '.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral") | " FAILED: \(.name) (\(.conclusion))"'
echo "$external_checks" | jq -r '.[] | select(.status == "completed" and .conclusion != "success" and .conclusion != "skipped" and .conclusion != "neutral" and .conclusion != "cancelled") | " FAILED: \(.name) (\(.conclusion))"'
else
echo "Waiting for: ${pending}"
fi
Expand Down
Loading