docs: update simplifier role to producer-only [doc-updater] - #3384
Conversation
There was a problem hiding this comment.
ACK — approve. Doc-only update; I verified every prose and table claim against the code referenced in the test plan.
Verification
Each claim in the rewritten simplifier section traces to source:
- "Producer only (#3381) … casts no verdict on anyone" — matches
orchestrator/review_graph.py:30-32and the producer-only banner dispatch inorchestrator/routes/pipelines.py:13309-13319. - "wake-only advisory edge over the upstream producer (
refiner/task_planner)" — matches the two edge definitionsReviewEdge("simplifier", "refiner", ReviewCriticality.ADVISORY, wake_only=True)(review_graph.py:253) and thetask_plannercounterpart (review_graph.py:304). The doc correctly describes the edge as ADVISORY criticality but wake-only. - "excluded from pending-review derivation" — confirmed at
orchestrator/routes/consensus.py:173,191(if producer in wake_only: continue). - "… and the reviewer confirm guards" — confirmed at
orchestrator/action_guards.py:457-461(wake-only producers excluded from the unconfirmed-producers set). - "woken … by the ordinary producer propose-arm … self-gates on the upstream draft existing, orienting-and-exiting until the upstream proposes" — matches the
wake_onlydocstring (review_graph.py:34-41) and the preamble comment (pipelines.py:13310-13312). - "never issues an ACK or NACK" — matches
review_graph.py:43-48. - "companion reviewed CRITICAL by
reviewer_refine/reviewer_plan" — unchanged and consistent with the table rows for those reviewers (lines 25, 30).
Table change
Dropping the dual-role: advisory reviewer label and the , advisory depends-on qualifier is correct. The simplifier still depends on the upstream draft (it self-gates on its existence), so refiner (refine) / task_planner (plan) remains an accurate Depends-On; the prior , advisory qualifier denoted a review relationship that no longer exists.
Completeness
I grepped the full file for simplifier / dual-role / advisory: no stale references to the old simplifier model remain. The other dual-role/advisory mentions correctly describe risk_analyst (#2809) and tester (#2749), which are unaffected.
No blocking issues. The doc now matches the landed behavior.
— Authored by egg
|
egg review completed. View run logs |
docs: update simplifier role to producer-only (#3381)
Update
docs/reference/agent-roles.mdto reflect the de-roling of thesimplifier from dual-role (producer + advisory reviewer) to producer-only,
landed in #3382.
producer" label and the ", advisory" depends-on qualifier
description of the new producer-only model — the simplifier retains a
wake-only advisory edge (structural marker only, no review obligation), is
woken by the producer propose-arm rather than the ack-arm, and never issues
an ACK or NACK on the upstream draft
Triggered by: #3382
Issue: none
Test Plan
in orchestrator/review_graph.py (ReviewEdge.wake_only) and
orchestrator/routes/pipelines.py (_build_brc_preamble)
Authored-by: egg