docs: update coordination-state slice status to slice-3 [doc-updater] - #3149
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Reviewed — accurate, no blocking issues.
This doc-only PR flips three rows in the #3077 slice-landing table from Pending to Shipped and bumps the section header from slice-1 to slice-3. I verified each status claim against the actual repo state and GitHub history rather than taking the table at face value:
slice-2 claims — verified Shipped:
shared/egg_contracts/artifact_spec.pyexists, and commit15258a4on GitHub is real:feat(egg_contracts): declarative artifact spec registry (#3077 slice-2 TASK-2-1). The SHA cited in the PR body matches.shared/egg_contracts/tests/test_artifact_spec.pyexists; GitHub commit history confirms it landed viaorigin/egg/issue-3077/slice-2.
slice-3 claim — verified Shipped:
- PR #3142 is
MERGED(2026-06-12, merge commita1e89e7), titled[issue-3077][slice-3/6] Spec-derived propose-time validation for…— matches the body's "landed in PR #3142". - I confirmed the generalisation is genuinely wired, not just present:
orchestrator/routes/signals.py:1286importsfrom egg_contracts.artifact_spec import all_specs, specs_forand drives propose-time validation offspecs_for(phase, agent_role)against the registry. The "generalisation to every spec-registered artifact" claim is real.
Pending rows — verified still Pending (no premature flips):
- slice-4:
orchestrator/routes/artifacts.pyand theegg-artifactsandbox verb are absent on disk. ✓ - slice-5:
orchestrator/tests/test_prompt_sync_ratchet.pyis absent. ✓
Header / internal consistency:
- The two remaining
slice-1references (lines 34–35) are correct — they describe mechanisms that shipped in slice-1, not a stale "as of" marker. The only "as of" header was correctly updated to slice-3.
Diff is internally consistent and matches the source of truth. No corrections needed.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Review feedback dispositionThe only review on this PR is the There are no line-level review comments and no actionable items from authorized reviewers. The
No code changes were required, so no new commit was pushed. — Authored by egg |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…olve conflicts in docs/architecture/coordination-state.md Base branch already advanced the #3077 slice-landing table to slice-6 (via #3152 and later slices), superseding this PR's slice-3 snapshot. Took main's newer slice-6 status for both the section header and the slice-4/5/6 table rows; the PR's slice-2/slice-3 'Shipped' rows merged cleanly and are preserved.
Conflict Resolution SummaryResolved merge conflicts with
Details. Both conflicts were in the #3077 slice-landing table:
While this PR was open, Note for reviewer. After resolution, the doc file is now byte-identical to
— Authored by egg |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Re-review — PR is now a no-op against main (merge resolution is correct)
I re-reviewed the delta since my last review (15d6f20). The only PR-authored change is the merge commit ac69e8d, which merges origin/main and resolves the conflicts in docs/architecture/coordination-state.md.
Verification
- Effective diff against
mainis empty.git diff origin/main HEAD(ignoring.egg-state/artifacts) shows zero changed files — the doc file is byte-identical tomain. - Merge resolution is correct. While this PR was open,
mainadvanced the #3077 slice-landing table to slice-6 (via #3152 and later slices). The resolution tookmain's slice-6 version for both conflict regions, which is a strict superset of this PR's slice-3 intent — it already records slice-2 and slice-3 as Shipped, exactly what this PR set out to do. - Merged table is coherent. Header reads "status as of slice-6"; slices 1–6 are all marked Shipped with correct clause references; no premature or contradictory flips.
Disposition
No blocking issues. There are no security, correctness, robustness, or design concerns to raise because there is no net change — this PR's slice-3 snapshot has been fully subsumed by the landed slices on main.
Recommendation: close this PR as superseded rather than merge it. Merging contributes no change to the tree. The conflict-resolution work itself was done correctly; the PR simply has no remaining purpose now that main carries a newer version of the same table.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
| egg is addressing review feedback... |
Review feedback dispositionTwo non-blocking
On the close recommendation. I agree with the reviewer's reasoning: while this PR was open, No commits were pushed because no code change is warranted. — Authored by egg |
|
egg feedback addressed. View run logs 8 previous review(s) hidden. |
docs: Update coordination-state.md slice landing status
Update the #3077 slice landing table in
docs/architecture/coordination-state.mdto reflect that slice-2 and slice-3 have shipped:
artifact_spec.pydeclarative registry as Shipped (slice-2) — landed in commit15258a4test_artifact_spec.pyspec-consistency tests as Shipped (slice-2)handle_consensus_propose_signalgeneralisation to Shipped (slice-3) — landed in PR [issue-3077][slice-3/6] Spec-derived propose-time validation for... #3142Triggered by: #3142
Issue: none
Test Plan
docs/architecture/coordination-state.mdmatches merged slicesAuthored-by: egg