Skip to content

docs: add egg_agent_tools to sandbox STRUCTURE.md [doc-updater] - #2997

Merged
jwbron merged 2 commits into
mainfrom
egg/doc-update-confluence-jira-mcp-tools
Jun 4, 2026
Merged

docs: add egg_agent_tools to sandbox STRUCTURE.md [doc-updater]#2997
jwbron merged 2 commits into
mainfrom
egg/doc-update-confluence-jira-mcp-tools

Conversation

@james-in-a-box

@james-in-a-box james-in-a-box Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Update documentation to reflect changes from d1c2fbd (feat(sandbox): expose Confluence/Jira gateway routes as MCP servers #2994 #2996):

  • Add egg_agent_tools/ to the sandbox section of docs/development/STRUCTURE.md — it was missing despite being the home of the 45-verb in-process SDK MCP server. The confluence.py and jira.py modules added in #2994 make this a good moment to document the package layout.

Other key docs (docs/reference/agent-tools.md, docs/guides/sdlc-pipeline.md, sandbox/agent-config/rules/environment.md, docs/index.md) were already updated as part of #2996 and need no changes.

Triggered by: #2996

Authored-by: egg

The egg_agent_tools/ package was missing from the sandbox section of
docs/development/STRUCTURE.md. It hosts the in-process SDK MCP server
(45 tools, 7 namespaces) that agents use instead of shelling out to
egg-contract/egg-orch. The confluence.py and jira.py modules added in
#2994 make this the right moment to document the package layout.

Triggered by: d1c2fbd (feat(sandbox): expose Confluence/Jira gateway
routes as MCP servers #2994 #2996)

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc-only PR adding 13 lines to docs/development/STRUCTURE.md describing the sandbox/egg_agent_tools/ package. Verified every factual claim against the code on this branch:

  • Tool/namespace countsREGISTRATIONS across tools/{brc,confluence,jira,message,phase,progress,sdlc,task}.py enumerate to 45 tools across 7 namespaces (message.py registers under brc, so namespace count is right despite the 8 source modules).
  • server.pybuild_sandbox_mcp_server() at server.py:69 builds one SDK server per namespace; SYSTEM_PROMPT_NUDGE is module-level at server.py:61 (assigned at import). ✅
  • schemas.pyderive_schema_from_argparse at schemas.py:73. ✅
  • push.py — module docstring confirms it's the consensus_push helper shared between egg-orch consensus propose --push and mcp__brc__propose. ✅
  • handlers/_gateway.pygateway_request (line 190) and gateway_data_request (line 235). ✅
  • Confluence tools (8 read-only mirrors)page_get, page_descendants, page_footer_comments, page_inline_comments, space_pages, space_list, search, execute (GET-only). ✅
  • Jira tools (9 mirrors: 5 reads + 4 writes) — reads: ticket_get, ticket_comments, ticket_remotelinks, search, execute; writes: ticket_create, ticket_edit, ticket_comment_add, link_create. ✅
  • All sibling files referenced by ... exist in both handlers/ and tools/. ✅

Non-blocking suggestion

The jira description reads 9 gateway mirrors (reads + 4 writes) — slightly asymmetric. Consider (5 reads + 4 writes) for clarity; matches the verified split and parallels the explicit count in the confluence line.

No correctness, security, or accuracy issues. The PR delivers exactly what the body advertises and the documentation tracks the code.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

This comment has been minimized.

@james-in-a-box

james-in-a-box Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the verification and the suggestion!

Disposition

  • Jira description asymmetry (9 gateway mirrors (reads + 4 writes)(5 reads + 4 writes))fixed-in-PR (commit aed4825). Updated docs/development/STRUCTURE.md to read 9 gateway mirrors (5 reads + 4 writes), matching the explicit split you verified and parallelling the confluence line.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of delta 36b2e02..aed4825.

The new commit contains a single one-line edit to docs/development/STRUCTURE.md:232, changing the jira mirror description from (reads + 4 writes) to (5 reads + 4 writes). This is exactly the non-blocking clarification from my prior review, addressed verbatim.

Verified the count is still accurate against sandbox/egg_agent_tools/tools/jira.py:

  • Reads (5): ticket_get, ticket_comments, ticket_remotelinks, search, execute
  • Writes (4): ticket_create, ticket_edit, ticket_comment_add, link_create

The line now parallels the adjacent confluence entry ("8 read-only gateway mirrors"), so the symmetry concern from the prior review is resolved. No other files changed; no new issues introduced.

Approving.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

james-in-a-box Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author
egg is addressing review feedback...

@james-in-a-box

james-in-a-box Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the re-review!

Disposition

  • Re-review of delta 36b2e02..aed4825 confirming the jira mirror split clarificationdisagree (no actionable change requested). The re-review verifies that commit aed4825 correctly addressed the non-blocking suggestion from the prior review ("5 reads + 4 writes") and explicitly concludes "Approving." No new findings, no new actionable feedback — nothing to fix in this round.

— Authored by egg

@james-in-a-box

james-in-a-box Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

egg feedback addressed. View run logs

4 previous review(s) hidden.

@jwbron
jwbron merged commit ac078a6 into main Jun 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant