docs: add egg_agent_tools to sandbox STRUCTURE.md [doc-updater] - #2997
Conversation
The egg_agent_tools/ package was missing from the sandbox section of docs/development/STRUCTURE.md. It hosts the in-process SDK MCP server (45 tools, 7 namespaces) that agents use instead of shelling out to egg-contract/egg-orch. The confluence.py and jira.py modules added in #2994 make this the right moment to document the package layout. Triggered by: d1c2fbd (feat(sandbox): expose Confluence/Jira gateway routes as MCP servers #2994 #2996) Authored-by: egg
There was a problem hiding this comment.
Doc-only PR adding 13 lines to docs/development/STRUCTURE.md describing the sandbox/egg_agent_tools/ package. Verified every factual claim against the code on this branch:
- Tool/namespace counts —
REGISTRATIONSacrosstools/{brc,confluence,jira,message,phase,progress,sdlc,task}.pyenumerate to 45 tools across 7 namespaces (message.pyregisters underbrc, so namespace count is right despite the 8 source modules). server.py—build_sandbox_mcp_server()at server.py:69 builds one SDK server per namespace;SYSTEM_PROMPT_NUDGEis module-level at server.py:61 (assigned at import). ✅schemas.py—derive_schema_from_argparseat schemas.py:73. ✅push.py— module docstring confirms it's theconsensus_pushhelper shared betweenegg-orch consensus propose --pushandmcp__brc__propose. ✅handlers/_gateway.py—gateway_request(line 190) andgateway_data_request(line 235). ✅- Confluence tools (8 read-only mirrors) —
page_get,page_descendants,page_footer_comments,page_inline_comments,space_pages,space_list,search,execute(GET-only). ✅ - Jira tools (9 mirrors: 5 reads + 4 writes) — reads:
ticket_get,ticket_comments,ticket_remotelinks,search,execute; writes:ticket_create,ticket_edit,ticket_comment_add,link_create. ✅ - All sibling files referenced by
...exist in bothhandlers/andtools/. ✅
Non-blocking suggestion
The jira description reads 9 gateway mirrors (reads + 4 writes) — slightly asymmetric. Consider (5 reads + 4 writes) for clarity; matches the verified split and parallels the explicit count in the confluence line.
No correctness, security, or accuracy issues. The PR delivers exactly what the body advertises and the documentation tracks the code.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks for the verification and the suggestion! Disposition
— Authored by egg |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Re-review of delta 36b2e02..aed4825.
The new commit contains a single one-line edit to docs/development/STRUCTURE.md:232, changing the jira mirror description from (reads + 4 writes) to (5 reads + 4 writes). This is exactly the non-blocking clarification from my prior review, addressed verbatim.
Verified the count is still accurate against sandbox/egg_agent_tools/tools/jira.py:
- Reads (5):
ticket_get,ticket_comments,ticket_remotelinks,search,execute - Writes (4):
ticket_create,ticket_edit,ticket_comment_add,link_create
The line now parallels the adjacent confluence entry ("8 read-only gateway mirrors"), so the symmetry concern from the prior review is resolved. No other files changed; no new issues introduced.
Approving.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
| egg is addressing review feedback... |
|
Thanks for the re-review! Disposition
— Authored by egg |
|
egg feedback addressed. View run logs 4 previous review(s) hidden. |
Update documentation to reflect changes from d1c2fbd (feat(sandbox): expose Confluence/Jira gateway routes as MCP servers #2994 #2996):
egg_agent_tools/to the sandbox section ofdocs/development/STRUCTURE.md— it was missing despite being the home of the 45-verb in-process SDK MCP server. Theconfluence.pyandjira.pymodules added in #2994 make this a good moment to document the package layout.Other key docs (
docs/reference/agent-tools.md,docs/guides/sdlc-pipeline.md,sandbox/agent-config/rules/environment.md,docs/index.md) were already updated as part of #2996 and need no changes.Triggered by: #2996
Authored-by: egg