docs: add _module_loader.py to gateway structure listing [doc-updater] - #2347
Conversation
There was a problem hiding this comment.
Review: docs-only addition of _module_loader.py to STRUCTURE.md
Verdict: LGTM — single-line documentation addition, accurate and well-scoped.
Verification performed
-
File exists:
gateway/_module_loader.pyis present at the path documented (added in #2325, commit 7e79d8c). -
Description accuracy: The new entry's note —
Sibling-module bootstrap loader (isolated to keep
gateway.pyout of the dynamic-import seed set; do not add gateway imports here)is a faithful summary of the file's own module docstring (
gateway/_module_loader.py:1-18), which explains that the importlib primitives were extracted into a leaf module sogateway.gatewaywould no longer be flagged as a dynamic-import seed byscripts/select_tests.py, and warns "Do NOT add gateway-package imports here." -
Companion-doc claim: PR body asserts "
docs/guides/testing.mdwas already updated in the same commit as the code change (#2325)." Confirmed —git show 7e79d8c -- docs/guides/testing.mdshows §2/§4/§7/§10 updates landed with the code change, so no further edits to that file are needed. -
Placement: Listed right after
gateway.py, which groups it thematically with the bootstrap it was extracted from. Acceptable; the surrounding listing isn't strictly alphabetical anyway (e.g.,policy.pyprecedesfork_policy.py).
Issues found
None. No security, correctness, robustness, or design concerns — this is purely an index entry pointing at an already-merged file.
Non-blocking observations
- The inline note is long for a code-fence comment (one of the longer entries in the table). It's still readable; not worth churning on.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
| egg is addressing review feedback... |
Review feedback addressedThanks for the thorough review. The reviewer's verdict was LGTM with no actionable issues found, and one non-blocking observation. Per-item disposition
No code changes pushed; review surfaced no actionable items. — Authored by egg |
|
egg feedback addressed. View run logs 1 previous review(s) hidden. |
Update STRUCTURE.md to include the new
gateway/_module_loader.pyfileintroduced in #2325.
_module_loader.pyentry to the gateway file listing indocs/development/STRUCTURE.md, with a brief note explaining itspurpose (sibling-module bootstrap that must stay import-free of
gateway packages to keep the dynamic-import seed set small)
docs/guides/testing.mdwas already updated in the same commit as thecode change (#2325) and does not need further edits.
Triggered by: 7e79d8c (Fix #2320: narrow gateway/*.py edits via bare-name AST resolver)
Authored-by: egg