Skip to content

docs: update lens reviewer criticality in README [doc-updater] - #2160

Merged
jwbron merged 1 commit into
mainfrom
egg/doc-update-lens-reviewer-criticality
Apr 27, 2026
Merged

docs: update lens reviewer criticality in README [doc-updater]#2160
jwbron merged 1 commit into
mainfrom
egg/doc-update-lens-reviewer-criticality

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Update documentation to reflect changes from 08e8a7f:

The stale wording ("advisory security and concurrency lens reviewers") was the only doc inconsistency; docs/reference/agent-roles.md and docs/guides/concurrent-execution.md were already updated in the same commit.

Triggered by: #2152

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. One-line doc fix; verified accurate.

Verification

  • README.md:105 previously read "advisory security and concurrency lens reviewers add targeted cross-file analysis."
  • PR #2139 (commit 08e8a7f) promoted reviewer_security and reviewer_concurrency from ADVISORY to CRITICAL and updated docs/reference/agent-roles.md and docs/guides/concurrent-execution.md, but missed README.md.
  • Authoritative wording in docs/reference/agent-roles.md: "CRITICAL — a NACK blocks consensus until the producer re-proposes (#2139; promoted from ADVISORY)."
  • Authoritative wording in docs/guides/concurrent-execution.md: "a NACK from either blocks consensus until the producer re-proposes (#2139)."
  • New README wording — "block consensus on a NACK" — is consistent with both.

Other README mentions checked

  • README.md:137 (✓ reviewer_security ✓ reviewer_concurrency in pipeline diagram) is unaffected — it just shows they ran, no criticality claim. No change needed.
  • No other "advisory" references to these roles remain in README.md.

No blocking issues. CI is green except for the in-progress egg-reviewer check itself.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

Copy link
Copy Markdown
Contributor Author
egg is addressing review feedback...

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg feedback addressed. View run logs

1 previous review(s) hidden.

@jwbron
jwbron merged commit 601bb4b into main Apr 27, 2026
22 checks passed
james-in-a-box Bot added a commit that referenced this pull request Apr 28, 2026
Co-authored-by: jwbron <8340608+jwbron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant