docs: document mcp__brc__confirm ok=False for pending_acks [doc-updater] - #2088
Merged
Conversation
Update documentation to reflect changes from c2eaea9: - agent-tools.md: clarify that mcp__brc__confirm returns ok=False when the orchestrator rejects the transition (pending_acks), not just on hard errors. Equivalent to CLI exit code 2 vs 0. - concurrent-execution.md: extend the pending_acks note to cover the MCP tool response (ok=False / ok=True) alongside the CLI exit codes. Triggered by: #2083 Authored-by: egg
Contributor
There was a problem hiding this comment.
Approve. Doc-only change accurately documenting mcp__brc__confirm behavior fixed in #2083.
Verified both edits against the handler at sandbox/egg_agent_tools/handlers/brc.py:223-258:
pending = body.get("status") == "pending_acks"and"ok": not pending— the new prose ("ok=Truewhen the transition succeeded;ok=Falsewithstatus='pending_acks'when rejected") matches the implementation exactly.- The handler docstring already encodes this contract; the reference table cell now agrees.
- The CLI exit-code 0-vs-2 mapping is consistent with the existing exit-code-2 note in
concurrent-execution.md:344. - Both edits are placed correctly (the natural spots — the
mcp__brc__confirmrow and the existingpending_acksnote).
No code paths affected. Low-risk merge.
— Authored by egg
Contributor
Author
|
egg review completed. View run logs |
jwbron
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect the behavior fix in c2eaea9 (#2083):
brc_confirm/mcp__brc__confirmpreviously returnedok=Trueeven when the orchestrator rejected the CONFIRMED transition withstatus="pending_acks". The fix makesok=Falsein that case. Without this doc update, agents reading the tool reference would not knowokis meaningful for confirm — they'd have to checkstatusexplicitly.docs/reference/agent-tools.md: Extended themcp__brc__confirmdescription to noteok=Falsemeanspending_acks(transient rejection) andok=Truemeans the transition succeeded. Mapped to CLI exit code 0 vs 2.docs/guides/concurrent-execution.md: Extended the existingpending_acksnote to cover the MCP tool response (ok=False/ok=True) alongside the already-documented CLI exit codes.Test Plan
brc.pyhandler behavior.Triggered by: #2083
Authored-by: egg