Skip to content

docs: add #1882 gateway/orchestrator files to STRUCTURE.md [doc-updater] - #1960

Merged
jwbron merged 2 commits into
mainfrom
egg/doc-update-structure-1882
Apr 24, 2026
Merged

docs: add #1882 gateway/orchestrator files to STRUCTURE.md [doc-updater]#1960
jwbron merged 2 commits into
mainfrom
egg/doc-update-structure-1882

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Update STRUCTURE.md to reflect new modules introduced in #1882 (cbd831e).

Three new gateway files and two new orchestrator files were added by the auto-filter PR but not listed in the project structure doc:

  • gateway/filtered_push.py — per-commit rewriter that strips blocked paths from own commits while passing cross-role pulled commits bitwise-unchanged
  • gateway/commit_observer.py — gateway-inline observer that registers new SHAs with the authorship registry after each git-execute call
  • gateway/commit_registry_client.py — HTTP client for the orchestrator's commit-authorship registry (register + lookup_bulk)
  • orchestrator/commit_authorship_store.py — durable {sha → role} registry sharded by pipeline on the pipeline-state branch
  • orchestrator/routes/commit_authorship.py — register and lookup endpoints called by the gateway observer and push handler

The architecture doc (docs/architecture/gateway-auto-filter.md) and the index (docs/index.md) were already updated as part of #1937 and fully describe these components. This PR just adds them to the directory-level inventory in STRUCTURE.md.

Triggered by: #1937

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc-only change, all five referenced files verified to exist on main, descriptions match file docstrings. One non-blocking ordering issue.

Non-blocking

routes/commit_authorship.py placement breaks alphabetical order — The routes/ subsection is currently alphabetical (anchorscontainersdecisions → … → pipelinesprogresssignals). The new commit_authorship.py entry is placed after pipelines.py, but it should go between anchors.py and containers.py to maintain the established ordering.

 │   ├── anchors.py          # Agent anchor CRUD and team anchor generation endpoints
+│   ├── commit_authorship.py # Commit-authorship registry endpoints (register + lookup); called by gateway commit observer and push handler
 │   ├── containers.py       # Container management endpoints

The gateway section and top-level orchestrator section use loose thematic grouping rather than strict alphabetical order, so those placements are fine.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

This comment has been minimized.

@james-in-a-box james-in-a-box Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Moved commit_authorship.py entry to its correct alphabetical position between anchors.py and containers.py in the routes/ subsection. Fixed in 9925a63.

— Authored by egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of changes since 24ee0e9.

The single new commit (9925a63) correctly addresses the alphabetical ordering feedback from the previous review — commit_authorship.py is now placed between anchors.py and containers.py in the routes/ subsection.

Verified:

  • All five files added across both commits exist on main
  • Descriptions match file purposes
  • Gateway section maintains its thematic grouping convention
  • routes/ section maintains alphabetical order

No issues found.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

2 previous review(s) hidden.

@jwbron
jwbron merged commit 1736bef into main Apr 24, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant