docs: clarify RUNTIME_TICK trigger sources [doc-updater] - #1822
Merged
Conversation
![egg-reviewer[bot]](https://avatars.githubusercontent.com/u/8340608?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verified against the implementation in orchestrator/kubernetes_monitor.py:
_reconciliation_sweepcalls_run_runtime_tick_checks()at line 561 (added by #1817)_run_runtime_tick_checksdocstring (lines 216-222) documents both call sites (_check_podand_reconciliation_sweep)- Test coverage exists at
test_kubernetes_monitor.py::TestRuntimeTickConsensusStallWiring::test_reconciliation_sweep_invokes_runtime_tick
The updated documentation text accurately reflects the current behavior: RUNTIME_TICK is now fired from both pod state transitions and the periodic reconciliation sweep, and the rationale (ensuring stall recovery for quiescent pipelines) matches the code comments and #1817 PR description.
No issues found.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
egg review completed. View run logs 1 previous review(s) hidden. |
james-in-a-box Bot
added a commit
that referenced
this pull request
Apr 22, 2026
Co-authored-by: jwbron <8340608+jwbron@users.noreply.github.com>
james-in-a-box Bot
added a commit
that referenced
this pull request
Apr 22, 2026
Co-authored-by: jwbron <8340608+jwbron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: clarify RUNTIME_TICK trigger sources [doc-updater]
Update documentation to reflect changes from f897961 (Fix #1813):
docs/architecture/orchestrator.md: TheRUNTIME_TICKlifecycle entry previously stated it was only "triggered by pod state changes". After Plan phase stalls after BRC consensus: producer agents never call signal complete #1813, it is also fired on every periodic_reconciliation_sweepso pipelines with no pod churn (e.g. all agents quietly polling post-BRC consensus) still run the stall-recovery path. Updated the entry to reflect both trigger sources.Triggered by: #1817
Authored-by: egg