Fix E2E deterministic test DNS resolution - #150
Merged
Conversation
added 2 commits
February 6, 2026 04:38
The run_claude_structured() helper was missing the --add-host flag needed to map egg-gateway to the gateway container IP. It was also passing GATEWAY_URL under the wrong env var name (EGG_GATEWAY_URL), causing the sandbox entrypoint to fall back to the default hostname which could not be resolved without --add-host. Mirrors the production container launch in sandbox/egg_lib/runtime.py which correctly uses --add-host and GATEWAY_URL.
jwbron
approved these changes
Feb 6, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gateway DNS resolution in E2E deterministic tests
All three deterministic E2E tests (test_simple_prompt_completes,
test_file_creation_via_prompt, test_git_status_via_prompt) were failing
because the sandbox container could not resolve the
egg-gatewayhostname. The
run_claude_structured()helper in conftest.py had twoissues compared to the production launcher in
sandbox/egg_lib/runtime.py:--add-host egg-gateway:<ip>flag — the container had no DNSmapping for the gateway hostname.
EGG_GATEWAY_URLbut the sandboxentrypoint reads
GATEWAY_URL, so the entrypoint fell back to thedefault
http://egg-gateway:9848which required DNS that wasn'tconfigured.
This aligns the test helper with the production container launch code.
Issue: none
Test plan:
Authored-by: egg