Fix git push using wrong credentials from actions/checkout - #149
Merged
Conversation
jwbron
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gateway push using GITHUB_TOKEN instead of bot App token
When the egg action runs in GitHub Actions,
actions/checkout@v4persists the GITHUB_TOKEN as an
http.extraheaderin.git/config.This extraheader takes precedence over the
GIT_ASKPASScredentialhelper that the gateway sets up with the bot App token. Since the
GITHUB_TOKEN lacks
workflowsscope, pushes that include.github/workflows/files are rejected.This caused the bot to be unable to push workflow files in PR #146,
even though the GitHub App has the correct permissions.
Two fixes applied (defense in depth):
Gateway (
gateway.py): Clearhttp.extraheadervia-c http.extraheader=when running git push, ensuring only thegateway's
GIT_ASKPASScredential helper is used.Workflow (
on-mention.yml): Addpersist-credentials: falseto both checkout steps so
actions/checkoutdoesn't write theGITHUB_TOKEN to
.git/configin the first place.Issue: none
Related: #146
Test plan:
Authored-by: egg