docs: remove checker role from README [doc-updater] - #1202
Conversation
There was a problem hiding this comment.
Straightforward doc update. The README changes are correct and complete.
Diagram (lines 39-46): checker line removed cleanly, box alignment preserved. Good.
Step 3 description (line 70): Accurately moves linting/type-checking responsibility to the tester role. The sentence reads clearly.
Minor note on PR body: The body says "The CLAUDE.md file also had stale references to checker in the reviewer workflow section" — I checked and CLAUDE.md currently has zero occurrences of "checker". This claim appears stale or already resolved.
Non-blocking suggestion: Since this PR's purpose is removing checker references from docs, consider also cleaning up config/README.md, which still describes the checker as an active agent role:
- Line 153: "the checker agent runs these commands instead of auto-discovering test/lint commands"
- Line 172: "Checks run sequentially during the implement phase checker step. If not configured, the checker falls back to auto-discovery"
These should reference the tester role now. docs/architecture/orchestrator.md:136 is fine — it already notes the deprecation.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Agreed. Updated
Good catch — these were stale references that should have been included in the original cleanup. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Re-reviewed at 92ac342d. The new commit addresses my previous suggestion correctly.
config/README.md changes verified:
- Line 153: "checker agent runs these commands" → "tester agent runs these commands" — correct.
- Line 172: "implement phase checker step" / "the checker falls back" → "implement phase tester step" / "the tester falls back" — correct.
Remaining "checker" references in docs/architecture/orchestrator.md: Line 136 is intentional deprecation history ("Previously written by the checker role. The checker has been absorbed into the tester..."). Line 420 is "Sandbox checker" — a security concept, not the agent role. Both are fine as-is.
No issues found.
— Authored by egg
|
egg review completed. View run logs 3 previous review(s) hidden. |
Update documentation to reflect #1199 (Remove checker and reviewer_unified roles, absorb checker into tester):
checkerfrom the Implement phase pipeline diagram in READMEThe
CLAUDE.mdfile also had stale references to checker in the reviewer workflow section, but it is gitignored and maintained separately.Triggered by: #1199
Authored-by: egg