Skip to content

docs: remove checker role from README [doc-updater] - #1202

Merged
jwbron merged 2 commits into
mainfrom
egg/doc-update-remove-checker-role
Mar 16, 2026
Merged

docs: remove checker role from README [doc-updater]#1202
jwbron merged 2 commits into
mainfrom
egg/doc-update-remove-checker-role

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Update documentation to reflect #1199 (Remove checker and reviewer_unified roles, absorb checker into tester):

  • Remove checker from the Implement phase pipeline diagram in README
  • Update step 3 description to reflect that the tester now handles linting and type-checking (previously described as a separate checker role)

The CLAUDE.md file also had stale references to checker in the reviewer workflow section, but it is gitignored and maintained separately.

Triggered by: #1199

Authored-by: egg

Update documentation to reflect changes from 31c7935:
- Remove checker from the Implement phase ASCII diagram
- Update step 3 description: tester now handles linting and type-checking

Triggered by: #1199

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward doc update. The README changes are correct and complete.

Diagram (lines 39-46): checker line removed cleanly, box alignment preserved. Good.

Step 3 description (line 70): Accurately moves linting/type-checking responsibility to the tester role. The sentence reads clearly.

Minor note on PR body: The body says "The CLAUDE.md file also had stale references to checker in the reviewer workflow section" — I checked and CLAUDE.md currently has zero occurrences of "checker". This claim appears stale or already resolved.


Non-blocking suggestion: Since this PR's purpose is removing checker references from docs, consider also cleaning up config/README.md, which still describes the checker as an active agent role:

  • Line 153: "the checker agent runs these commands instead of auto-discovering test/lint commands"
  • Line 172: "Checks run sequentially during the implement phase checker step. If not configured, the checker falls back to auto-discovery"

These should reference the tester role now. docs/architecture/orchestrator.md:136 is fine — it already notes the deprecation.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

This comment has been minimized.

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

Agreed. Updated config/README.md to replace the two checker references with tester:

  • Line 153: "the checker agent runs these commands" → "the tester agent runs these commands"
  • Line 172: "implement phase checker step" / "the checker falls back" → "implement phase tester step" / "the tester falls back"

Good catch — these were stale references that should have been included in the original cleanup.

@james-in-a-box

This comment has been minimized.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 92ac342d. The new commit addresses my previous suggestion correctly.

config/README.md changes verified:

  • Line 153: "checker agent runs these commands" → "tester agent runs these commands" — correct.
  • Line 172: "implement phase checker step" / "the checker falls back" → "implement phase tester step" / "the tester falls back" — correct.

Remaining "checker" references in docs/architecture/orchestrator.md: Line 136 is intentional deprecation history ("Previously written by the checker role. The checker has been absorbed into the tester..."). Line 420 is "Sandbox checker" — a security concept, not the agent role. Both are fine as-is.

No issues found.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

3 previous review(s) hidden.

@jwbron
jwbron merged commit 148685c into main Mar 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant