docs: Update agent-mode-design for Agent SDK migration [doc-updater] - #1191
Merged
Conversation
Contributor
There was a problem hiding this comment.
Documentation change accurately reflects the codebase. Verified:
- Import path
from egg_agent import build_agent_commandmatchesshared/egg_agent/__init__.pyexport and existing usage inorchestrator/routes/pipelines.py. build_agent_command(prompt=..., max_turns=1)matches the real signature inshared/egg_agent/command.py.- Return type
list[str]is compatible with thecommand=parameter onspawn_agent_container().
No issues.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
egg review completed. View run logs 1 previous review(s) hidden. |
jwbron
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: Update agent-mode-design for Agent SDK migration
Update code example in agent-mode-design.md that was rendered stale by
commit 487fea5 ("Migrate orchestrator from claude --print to Agent SDK").
The "Anti-pattern 3" section's "Right approach" example previously showed
["claude", "--print", "--max-turns", "1", ...]as the correct way todelegate LLM calls from the orchestrator to sandbox containers. With the
migration, the orchestrator now uses
build_agent_command()which returnspython3 -m egg_agent— not theclaudeCLI. The example now correctlyreflects this pattern.
Issue: none
Test plan:
shared/egg_agent/command.pybuild_agent_command()signature and usage.Authored-by: egg