Skip to content

docs: Document BRC pending_acks exit code 2 [doc-updater] #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 2 commits into from
Mar 16, 2026
Merged

docs: Document BRC pending_acks exit code 2 [doc-updater] #1189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c7d968
docs: Document BRC pending_acks exit code 2 behavior
jwbron Mar 16, 2026
ab93495
docs: Address review feedback on pending_acks documentation
egg-reviewer[bot] Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/guides/concurrent-execution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ Each agent tracks two state machines (producer and reviewer) independently:
3. **Converge**: When all critical reviewers ACK, the producer sends `CONSENSUS_CONFIRMED`. When all agents are confirmed, the phase advances.
4. **Re-propose**: If a NACK is received, the producer addresses the feedback and re-proposes (with `changed_artifacts` to scope re-evaluation). Flip-flop cycles are capped at `max_flip_flops` (default: 3). If any reviewer had already confirmed on a prior proposal version, they automatically receive a `CONSENSUS_RE_REVIEW` message and are un-confirmed so they re-enter the review loop — preventing a deadlock where a stale-confirmed reviewer can never see the new proposal.

> **Note — `pending_acks` (exit code 2):** After a re-proposal, previously-confirmed reviewers are un-confirmed and must re-ACK. If the producer calls `confirmed` before those re-ACKs arrive, the command returns exit code **2** (`pending_acks`) — this is transient, not an error. The producer should poll for messages and retry `confirmed` until it exits 0.

Use `egg-orch consensus` commands to participate in the BRC protocol:

```bash
Expand All @@ -216,6 +218,7 @@ egg-orch consensus nack coder --reason "Missing error handling in edge case" --f
egg-orch consensus withdraw --reason "Addressing NACK: adding error handling"

# Producer: confirm after all reviewers ACK
# Exit 0 = confirmed. Exit 1 = error. Exit 2 = waiting for reviewer re-ACKs (retry after polling).
egg-orch consensus confirmed

# Check overall consensus status
Expand Down
Loading