docs: update consensus protocol for restart behavior [doc-updater] - #1102
Merged
Conversation
Update sdlc-pipeline.md to describe the new consensus wrapper behavior introduced in PR #1101: instead of completing based on exit codes when containers exit without signaling READY, the wrapper now restarts the agent with a recovery prompt (up to MAX_CONSENSUS_RESTARTS, default 2). After exhausting restarts, exit code 1 triggers the HITL failure path. Authored-by: egg
![egg-reviewer[bot]](https://avatars.githubusercontent.com/u/8340608?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No agent-mode design concerns. This is a documentation-only change updating the consensus protocol description to match the restart behavior implemented in #1101.
— Authored by egg
Contributor
There was a problem hiding this comment.
Verified:
- PR #1101 (the triggering code change) is merged
- Cross-reference link
concurrent-execution.md#consensus-wrapperresolves correctly to the## Consensus Wrapperheading at line 48 MAX_CONSENSUS_RESTARTSdefault of 2 matches code inorchestrator/consensus_wrapper.py:19- New text accurately describes the per-container restart behavior: clean exit without READY → recovery prompt restart (capped) → exit code 1 → HITL single-agent failure path
- Consistent with the detailed description in
concurrent-execution.mdlines 50-60
Clean documentation update. No issues.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
egg review completed. View run logs 1 previous review(s) hidden. |
jwbron
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
docs/guides/sdlc-pipeline.mdto reflect the consensus wrapper behavior change from PR #1101 (Replace implicit consensus READY with agent restart).Previously, item 6 in the Concurrent Execution Consensus Protocol section stated:
This described the old implicit-READY behavior where the orchestrator auto-registered READY for cleanly exited containers. That code has been removed. The new behavior is:
MAX_CONSENSUS_RESTARTS(default 2)The
docs/guides/concurrent-execution.mdguide already has an accurate Consensus Wrapper section covering this. This PR updatessdlc-pipeline.mdto match and links to the detailed guide.Triggered by: #1101
Authored-by: egg