Family mismatch on dual stack environments breaks whitelist #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dual stack environments, r->useragent_addr might return an IPv4 mapped IPv6 address instead of a regular IPv4 address. In that case, apr_sockaddr_t->family will return AF_INET6 instead of AF_INET and will not take any IPv4 entries on the whitelist into account. This can results in whitelisted IPv4 address to be blocked anyway.
This PR solves this by adding additional checks to see if this is in fact an IPv4 mapped IPv6 address, and adjusts the matching logic accordingly.