Store sessions in db and extend token sessions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store user sessions in Crux rather than in an atom to allow for multiple instances of site to access the same sessions and to persist sessions between restarts. These changes also update the openid connect tests to assert that the expected sessions are created in the database. The expiry time of sessions created by calling the token endpoint has been extended from 1 hour to 1 week. Sessions created by logging in by basic auth have been reduced to 1 week from 1 month to be consistent.
elken
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store user sessions in Crux rather than in an atom to allow for multiple instances of site to access the same sessions and to persist sessions between restarts. These changes also update the openid connect tests to assert that the expected sessions are created in the database.
The expiry time of sessions created by calling the token endpoint has been extended from 1 hour to 1 week. Sessions created by logging in by basic auth have been reduced to 1 week from 1 month to be consistent. This change has been made to resolve the issue of users being automatically logged out after long periods of inactivity.