feat: Update OTEL deps #52
Conversation
- upgrade @sentry/instrumentation to ^0.52.1 The main change that this brings in is https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.52.1, which pins `import-in-the-middle` to have caret range. This allows users to get important bug fixes with `import-in-the-middle`. - upgrade @opentelemetry/semantic-conventions to ^1.25.1 This doesn't have any notable impact, but figured I'd upgrade it while I'm here
|
Hey @justindsmith, any chance to get this merged and released? FWIW we could even bump this to 0.53.0 now, which has been released in the meanwhile @AbhiPrasad |
…13587) This bumps all our internal OTEL instrumentation to their latest version. Mainly, this fixes two things: * Mongoose now supports v7 & v8 open-telemetry/opentelemetry-js-contrib#2353 * A variety of bug fixes, including a problem with http.get in ESM mode open-telemetry/opentelemetry-js#4857 - See: https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.53.0 Related: * open-telemetry/opentelemetry-js#4975 Issue about relaxing deps in "core" instrumentation packages * PR to bump deps in `@prisma/instrumentation`: prisma/prisma#25160 * PR to bump deps in `opentelemetry-instrument-remix`: justindsmith/opentelemetry-instrumentations-js#52 * PR to bump deps in `opentelemetry-instrumentation-fetch-node`: gas-buddy/opentelemetry-instrumentation-fetch-node#17 (which will also be superseded by #13485 eventually) * Closes #11499
|
gentle ping @justindsmith, would really appreciate a release with this, as this fixes a multitude of issues with import-in-the-middle that have since been resolved! |
|
@justindsmith want me to rebase and bump the otel deps again? Or merge this in, and do another otel bump in another PR? |
|
@AbhiPrasad sorry for the delay on this! I tried to bump the otel deps on your branch but didn't have access. I tried to apply this change locally and it seems that there are some broken tests, though I'm still not sure if the issue is because of this version upgrade or just because remix has changed some internal structures that we need to patch. I'm going to check again tonight to see if I can narrow down the issue and will let you know! |
|
Sorry for the delay in this! I'm not sure why the actions weren't running here, but I went ahead and applied the upgrade in #57 and #58 and published a v0.8.0 which should have all the changes from above: https://www.npmjs.com/package/opentelemetry-instrumentation-remix/v/0.8.0 I did try bumping to 0.53.x, but that seemed to fail some tests and I'd rather unblock everyone and fix those later. Let me know if any issues and thanks @AbhiPrasad for this original PR! |
The main change that this brings in is
https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.52.1, which pins
import-in-the-middleto have caret range. This allows users to get important bug fixes withimport-in-the-middle. There are numerousimport-in-the-middlebugs that have been fixed, which is important for ESM users.This doesn't have any notable impact, but figured I'd upgrade it while I'm here