Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI outputs broken link, path, and line number. #77

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Conversation

justindhillon
Copy link
Owner

Based on user feedback, the CLI has been changed to include file:line.

Before:

Broken Link: https://www.un.org/en/thispagedoesnotexist
Broken Link: https://www.un.org/en/thispagedoesnotexist
Broken Link: https://www.nasa.gov/unknown-page

After:

Broken Link: https://www.un.org/en/thispagedoesnotexist
Path: tests/links/brokenLinks
Line: 5

Broken Link: https://www.un.org/en/thispagedoesnotexist
Path: tests/links/subfolder/brokenLinks
Line: 5

Broken Link: https://www.nasa.gov/unknown-page
Path: tests/links/subfolder/brokenLinks
Line: 2

Thank you @kristapsk for the feedback! This resolves #76.

@justindhillon justindhillon merged commit e603124 into main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could also show file:line, not only URL of broken link
1 participant