Repository navigation
docs(squad): record VMM contiguous-KV route and managed-VMM-default decisions - #756
Merged
Merged
Conversation
Agents and the coordinator no longer wait for CI unless explicitly asked. Local targeted validation remains mandatory; CI failures are fixed forward. This prevents completed work and worktrees from idling on matrix jobs. Also records the user's delegation for evidence-backed architecture decisions, durable design-document updates, and parallel worktrees for independent work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d60eb808-7cc6-4abc-b48d-2a6dd3841624
…ecisions Two owner decisions that change the direction of in-flight work: - Multi-request batching (#750) uses VMM contiguous virtual addresses per sequence rather than paged attention, so kernels never learn page tables. This supersedes #721 stage 3 unless the route fails its crux. - Managed no-spill VMM becomes the default with automatic weight streaming (#755), sequenced behind #716 because offload and CUDA graph capture are mutually exclusive today. Both records carry the measured counter-evidence they must beat, so the decisions can be revisited on evidence rather than re-argued. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d60eb808-7cc6-4abc-b48d-2a6dd3841624
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 80.10% 79.36% -0.74%
==========================================
Files 331 331
Lines 135684 137462 +1778
Branches 135684 137462 +1778
==========================================
+ Hits 108686 109098 +412
- Misses 22704 24024 +1320
- Partials 4294 4340 +46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🔴 Benchmark Regression DetectedComparison of criterion micro-benchmarks: PR head vs merge-base, measured on the same runner in the same job (base first → PR second).
Visual flags: Host infoWhat this cannot catch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records two owner decisions that redirect in-flight work, each with the measured counter-evidence it has to beat.
Contiguous-VA KV for batching (#750). Each sequence gets its own contiguous device virtual address with physical granules mapped underneath on demand; the attention kernel keeps seeing a flat buffer and never learns page tables. This supersedes #721 stage 3 unless the route fails. The record carries the result it must beat: #721 stage 4 measured a stable full-context VA committing 1.5 GB where bucket growth commits 48 MB, because the decode kernel reads the full padded shape and masks, forbidding tail decommit.
Managed no-spill VMM as default (#755), with automatic weight streaming instead of hard OOM. Sequenced explicitly behind #716, because weight offload and CUDA graph capture are mutually exclusive today — flipping the default first would silently disable capture for exactly the models that need offload, giving back the 154 -> 34 segment collapse from #708/#728.
Docs only, no code paths touched.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com