Repository navigation
test(ep-cpu): report the affinity-capability skip instead of returning silently - #2119
Merged
Merged
Conversation
…g silently Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
justinchuby
enabled auto-merge (squash)
August 25, 2026 14:14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 80.71% 81.18% +0.46%
==========================================
Files 415 429 +14
Lines 205260 215175 +9915
Branches 205260 215175 +9915
==========================================
+ Hits 165681 174686 +9005
- Misses 34018 34717 +699
- Partials 5561 5772 +211
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a_successful_affinity_call_is_never_reported_as_an_unsupported_targetreturns silently whenallowed_cpus()isNone. Eight lines so that it says so.The test's only failure mode is a target that masks successfully while
AFFINITY_MASKING_SUPPORTEDsays it cannot. A run that never reached the call therefore proves nothing — but a barereturnproduces a log identical to a check that ran and passed. That is the fail-open shape this test was itself written to prevent, sitting in the test.Honest scope
allowed_cpus()returnsSomehere, so the skip is not taken. I verified the test still passes (1 passed, and no skip line printed, which is the expected result and also the proof the branch was not hit). I am not claiming this line is covered — I am claiming that if it is ever hit, it will be visible.Commands
Salvaged from #2084, which I am closing as superseded by #2034.