Repository navigation
Fix native server session lease test - #2118
Closed
justinchuby wants to merge 1 commit into
Closed
justinchuby wants to merge 1 commit into
justinchuby wants to merge 1 commit into
Conversation
Load the native server fixture through AppState so the driver carries its production model key, then bind, acquire, generate, and close through SessionRegistry lease APIs. Assert generation and close both release their leases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
+ Coverage 80.51% 80.70% +0.19%
==========================================
Files 414 429 +15
Lines 200017 215150 +15133
Branches 200017 215150 +15133
==========================================
+ Hits 161037 173638 +12601
- Misses 33462 35741 +2279
- Partials 5518 5771 +253
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppStateso its driver uses the production model-qualified session keySessionRegistryand close throughtake_for_closeTests
cargo check -p onnx-genai-server --features native-backend --all-targetscargo test -p onnx-genai-server --features native-backend --all-targetscargo test -p onnx-genai-server --libcargo fmt --all -- --checkcargo clippy -p onnx-genai-server --features native-backend --all-targets -- -D warnings