Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,29 @@ jobs:
--features onnx-genai-engine/native-backend,onnx-genai-server/native-backend
-- -D warnings

# The mirror image of the step above, and the other half of the same hole.
# That one turns the feature *on*, and it is the only `-D warnings` gate in
# this file that names these crates -- `Run clippy on all offline crates`
# cannot list them because they pull in `ort-sys`, and `CLI ORT`'s clippy
# steps name `onnx-genai-cli`, so `-D warnings` does not reach a dependency
# and dependencies do not build test targets anyway.
#
# So the *default* configuration of both crates was compiled by
# `Test ORT-backed workspace crates` and linted by nothing. Measured, not
# assumed: #1964 merged with `warning: function `test_session_decoder_runtime`
# is never used` in a green `CLI ORT` log. That warning was harmless; a real
# unused-code defect at default features has exactly the same signature and
# the same fate, in a log only read once something else has already failed.
#
# Most of this is cache-warm from the step above, which shares the whole
# dependency graph minus the feature. Both configurations are checked
# separately rather than as a union, because default is what ships.
- name: Check the default features compile clean
run: >-
cargo clippy --locked --all-targets
-p onnx-genai-engine -p onnx-genai-server
-- -D warnings

# No shipped artifact links MLAS: the wheel builds it only when someone
# opts in with NXRT_EP_CPU_RESEARCH_MLAS=1 on one of the platforms in
# python/nxrt-ep-cpu/setup.py: MLAS_TARGETS, and release automation never
Expand Down
2 changes: 1 addition & 1 deletion crates/onnx-genai-engine/src/pipeline/generation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,7 @@ pub(crate) fn test_decoder_runtime() -> anyhow::Result<WorkflowRuntime> {
/// the next. Nothing else about the workflow changes, so a session test and a
/// stateless test still differ in one declared property rather than in two
/// unrelated fixtures.
#[cfg(test)]
#[cfg(all(test, feature = "native-backend"))]
pub(crate) fn test_session_decoder_runtime() -> anyhow::Result<WorkflowRuntime> {
test_decoder_runtime_inner(true)
}
Expand Down
Loading