Skip to content

Fix real-model corpus coverage gate - #1858

Merged
justinchuby merged 1 commit into
mainfrom
justinchuby/fix-real-corpus-gate
Aug 23, 2026
Merged

justinchuby merged 1 commit into
mainfrom
justinchuby/fix-real-corpus-gate

Conversation

@justinchuby

Copy link
Copy Markdown
Owner

Summary

  • treat machines with no installed real-model corpus as legitimately empty
  • continue failing when corpus packages exist but every package is skipped or fails to load
  • remove the environment-variable escape hatch that could mask real coverage failures

Validation

  • cargo test -p onnx-genai-engine --test real_model_workflow_corpus (5 passed)

Signed-off-by: justinchuby justinchu@microsoft.com

Treat a runner with no installed corpus as an empty machine rather than requiring an environment-variable escape hatch. Still fail when corpus packages exist but every package was skipped or failed to load.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
@justinchuby
justinchuby merged commit 030a4c0 into main Aug 23, 2026
@justinchuby
justinchuby deleted the justinchuby/fix-real-corpus-gate branch August 23, 2026 15:49
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.76%. Comparing base (39b6b18) to head (bf78509).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
+ Coverage   80.61%   80.76%   +0.15%     
==========================================
  Files         414      414              
  Lines      203362   203362              
  Branches   203362   203362              
==========================================
+ Hits       163941   164247     +306     
+ Misses      33869    33561     -308     
- Partials     5552     5554       +2     
Flag Coverage Δ
cli-ort-linux 72.51% <ø> (ø)
cli-ort-windows 72.10% <ø> (+0.09%) ⬆️
mlas 85.33% <ø> (+0.09%) ⬆️
offline 80.91% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants