Repository navigation
ci(mobius): follow mobius main now that the producer stack has landed - #1765
Merged
Merged
Conversation
`Mobius metadata packages` cannot pass for anyone. It checks out
`onnxruntime/mobius` at `justinchuby/catalogue-diffusion-builds`, and that
branch was deleted:
git fetch ... +refs/heads/justinchuby/catalogue-diffusion-builds*:...
The process '/usr/bin/git' failed with exit code 1
The job runs on every `pull_request`, so it reddens PRs regardless of what
they change. It is the only failure on #1747 and one of the reds on #1764
and #1729.
The step's own comment gave the exit condition -- "Stacked with mobius#538
until its image/video workflow producer lands." mobius#538 merged today at
16:53 UTC and its branch was deleted on merge, which is why this started
failing today rather than gradually. The condition is met, so the pin comes
off.
Checked rather than assumed that main is the right target:
- mobius#538's merge commit b9c90433 compares `identical` to
mobius/main -- ahead 0, behind 0. Following main today fetches exactly
what the deleted branch carried, so this is not a content change.
- All three paths the job references exist at mobius/main:
tests/generate_onnx_genai_validation_packages.py,
tests/compare_onnx_genai_validation_packages.py, and
tests/fixtures/onnx_genai_workflows.
Tradeoff worth stating: `main` floats, so an upstream commit can redden this
repo with no local change. A SHA pin would remove that at the cost of the
job silently no longer conforming against the current producer -- which is
the entire point of a producer-conformance check. Tracking main is the
intent; the failure mode is a real red rather than a permanent one.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c80f8522-983c-47f7-8241-2155a823aabe
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
==========================================
- Coverage 80.67% 80.19% -0.48%
==========================================
Files 411 411
Lines 198661 198661
Branches 198661 198661
==========================================
- Hits 160267 159321 -946
- Misses 32972 33920 +948
+ Partials 5422 5420 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
justinchuby
added a commit
that referenced
this pull request
Aug 22, 2026
Resolve the Mobius producer-conformance workflow conflict by keeping the immutable producer revision (Mobius PR #537, f0e2acfd) rather than following mobius main (upstream #1765). Producer evidence tracks an immutable unmerged Mobius commit and remains non-gating via continue-on-error, so ONNX GenAI changes are not blocked while producer metadata catches newer admission capabilities from main. Preserves all Music3 encoded-audio work: buffered PCM16 WAV output contract, request_expanded.factor >= 1 fail-closed validation, text-assembly + compatible buffered-WAV speech capability detection, and nested hierarchical-audio conformance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobius metadata packagescurrently cannot pass for anyone, on any PR, regardless of content..github/workflows/mobius-producer-conformance.yml:28checks outonnxruntime/mobiusatjustinchuby/catalogue-diffusion-builds.git ls-remoteconfirms that branch no longer exists. The job triggers on everypull_request, so it is a blanket false red — it is the only failure on #1747, and one of the reds on #1764 and #1729.Why now
The step's own comment stated its exit condition:
mobius#538 merged today at 16:53 UTC ("Support compact SD and complete video diffusion workflows") and its branch was deleted on merge. That is why this went red today rather than degrading gradually. The stacking condition is satisfied, so the pin comes off.
Verified, not assumed
I did not just swap the ref and call it fixed — pointing at a branch that lacks the producer would only trade a fetch failure for a script failure.
b9c90433comparesidenticaltomobius/main—ahead_by: 0,behind_by: 0. So followingmaintoday fetches byte-equivalent content to what the deleted branch carried. This is a ref change, not a content change.mobius/main:tests/generate_onnx_genai_validation_packages.py,tests/compare_onnx_genai_validation_packages.py, and thetests/fixtures/onnx_genai_workflowsfixture directory.main.The real verification is this PR's own run of the job, since the failure is entirely in CI and cannot be reproduced locally. If it does not go green here, the diagnosis was incomplete and I would rather find that out on this PR than on someone else's.
Tradeoff, stated rather than hidden
ref: mainfloats. An upstream commit can redden this repo with no local change — the same class of externally-caused red I am removing here.A SHA pin would eliminate that, at the cost of the job no longer conforming against the current producer, which is the entire purpose of a producer-conformance check. Tracking
mainis the intent of the job, and its failure mode is an actionable red rather than a permanent one. If the upstream churn turns out to be noisy in practice, pinning-with-a-bump-process is the fallback, but that should be driven by observed churn rather than pre-emptively.Not addressed
This does not touch the other reds on #1764 (inherited
E0599from theRegisteredMemoryContext::devicebreakage, fixed on main by #1762 — those need a rebase) or #1729 (six genuine reds across Windows, macOS, and CUDA).