Repository navigation
style: restore cargo fmt on main - #1567
Merged
Merged
Conversation
`cargo fmt --all --check` is red on main, so every open PR fails the format gate regardless of its own contents. Two files drifted in #1562: `onnx-runtime-ep-cuda/src/optimizer.rs` and `onnx-runtime-ep-cuda/src/kernels/global_reduction.rs`. Formatting only -- `cargo fmt --all` output, no hand edits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 12 12
Lines 5475 5475
Branches 5475 5475
=======================================
Hits 4525 4525
Misses 757 757
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Aug 20, 2026
justinchuby
added a commit
that referenced
this pull request
Aug 20, 2026
## Problem `cargo fmt --all --check` is **red on `origin/main`** (`b77e3d3fc`), so every open PR fails the fmt gate on code it did not touch. #1578 repaired `crates/onnx-runtime-ep-cuda/src/kernels/normalization.rs` but left two rustfmt diffs in the *same crate's* `matmul_nbits.rs`: - `:19596` — a `.map().collect()` chain that fits on one line - `:19753` — a stray blank line before a closing brace ## Fix `cargo fmt --all`. One file, +1/-4, formatting only, no functional change. ## Verification ``` $ git log --oneline -1 b77e3d3 ci: restore a red main ... (#1578) $ cargo fmt --all --check # before Diff in .../ep-cuda/src/kernels/matmul_nbits.rs:19596 Diff in .../ep-cuda/src/kernels/matmul_nbits.rs:19753 exit 1 $ cargo fmt --all && cargo fmt --all --check # after exit 0 ``` This is the second time this session that a red-on-main fmt gate has blocked unrelated PRs (see #1567). Both were introduced by changes that landed without the fmt gate passing. Co-authored-by: Roy <roy@squad.local> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --all --checkis red onmain, so every open PR fails the format gate regardless of its own contents. I hit this validating an unrelated CPU change and the failure was in files I had never touched.Two files drifted in #1562:
crates/onnx-runtime-ep-cuda/src/optimizer.rscrates/onnx-runtime-ep-cuda/src/kernels/global_reduction.rsConfirmed pre-existing by running
rustfmt --checkagainstgit show origin/main:<file>rather than against my branch.Formatting only — the output of
cargo fmt --all, no hand edits, no behavioural change.