Skip to content

Repository navigation

fix(ci): account for the deleted ONNX_GENAI_GEMV_FOLDSCALE knob #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 2 commits into from
Aug 20, 2026
Merged

fix(ci): account for the deleted ONNX_GENAI_GEMV_FOLDSCALE knob #1536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
813b5fa
fix(ci): account for the deleted ONNX_GENAI_GEMV_FOLDSCALE knob
justinchuby Aug 20, 2026
cdfeeb8
Point the fold-scale retraction at 9.3, where the re-measurement is
justinchuby Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/scripts/verify_documented_env_vars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@
"dense-decode-megakernel-feasibility.md §9.2; the cp.async double-buffered "
"weight-load path regressed (−13%, 4 B/lane granularity) and was reverted, "
"not shipped",
"ONNX_GENAI_GEMV_FOLDSCALE": "retracted experiment knob documented in "
"dense-decode-megakernel-feasibility.md; the fold-scale GEMV it selected was "
"deleted by #1527 after the +2.7% failed to reproduce (re-measured as a 2.9% "
"cost), and the document says so where it is named",
"NXRT_AUTO_INSTALL_CUDA": "referenced in prose about a proposed installer step",
"NXRT_SQNBIT_PREFILL_MIN": "referenced in prose about a proposed tuning knob",
"ONNX_GENAI_BASE_URL": "client-side variable read by external tooling, not by this workspace",
Expand Down
4 changes: 3 additions & 1 deletion docs/research/dense-decode-megakernel-feasibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,9 @@ full 128-bit sector — that is a from-scratch kernel, out of scope for this bou
LOP3 (4×`lop3.b32` + debias) — that is *why* the ALU pipe is at 65%. The one remaining ALU lever is to
**fold the per-block scale into the dequant's zp-subtract**: replace the plain `q=(code-zp)` then a
separate `__hmul2(q, scale)` with a single `fma(code, scale, -zp*scale)`, dropping **4 `__hmul2` per 8
weights** (~20% fewer fp16 ALU ops in the MAC). Env `ONNX_GENAI_GEMV_FOLDSCALE`.
weights** (~20% fewer fp16 ALU ops in the MAC). Env `ONNX_GENAI_GEMV_FOLDSCALE` — **retracted**:
the kernel this selected was deleted by #1527 after the win failed to reproduce, so the variable
no longer exists and setting it does nothing. See the re-measurement in §9.3.

| variant | tok/s | Δ | dominant-kernel µs | DRAM% |
| --- | --- | --- | --- | --- |
Expand Down
Loading