NMEA Passthrough Improvements #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode for nmea local-genned messages, where it claims to be what it hears from your GPS chip. Added support for more spoofed sat types: beidou (BD or GB), navic, qzss, explicit multisat (instead of native). Added UI nicieties. Made screen display one nmea sentence in queue mode, as well as the local-gen ones, and the text buffer. Added GxTXT to gpsdata output, along with accuracy.
…l, didn't remove old gps_obj.enable_queue() from MenuFunctions.
…OPIES)" that needed fixing.
schrab
pushed a commit
to schrab/ESP32S3Marauder
that referenced
this pull request
Jul 3, 2024
NMEA Passthrough Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parsing of GxTXT messages:
gps -g text
Added GxTXT (first line only) to gpsdata output, along with accuracy.
Added all lines of text (if queue enabled) or first line of text (queue disabled) to the nmea screen display.
Added default native mode for nmea local-genned messages, where it claims to be what it hears from your GPS chip, instead of multisat by default. It auto-detects what to spoof unless you tell it.
Added support for more spoofed sat types: beidou (BD or GB), navic, qzss, explicit multisat (instead of native).
gps -n native is now default
gps -n all for old default
gps -n navic/qzss/beidou
gps -n beidou -b switches to beidou BD mode (default is GB), for the first part of the NMEA message ID (talker ID)
Added UI nicieties.
message at start of nmea stream
confirmation of gps -n type set request
help improvements (lemme know if it's taking up too much real-estate)
screen displays one extra non-understood/nonparsed/notimplemented nmea sentence when queue enabled in nmea, also
Efficiency and code-flow improvements
Refactored to move some repeated blocks into their own functions
locally-genned message type is now in its own routine, as it became complex
Removed superflouous branching, all branching handled when you ask to destroy queue
Moved enable_queue to Wifi start scan, so it can't be missed and need not be called everywhere
Most explicit handling of null pointers and reconstruction therefrom occurs in flush_queue now
TESTED ON: Flipper Dev Board ESP32 Marauder
NOT TESTED ON: A model with GPS and a screen. (hardware purchases pending)
I sent this to master. Sorry if you'd have prefered develop. I cloned form nmea, but that branch suddenly died by merge into master. So I figured I should get you my updates.