Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes: Allow base props "className" and "style" to work on all components, fix some event listener issues. #3

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Bugfixes: Allow base props "className" and "style" to work on all components, fix some event listener issues. #3

merged 6 commits into from
Apr 27, 2020

Commits on Apr 21, 2020

  1. Workaround to fix an issue that prevents className and style base pro… 

    …perties from being forwarded to web components. See github.com/facebook/react/issues/4933
    @weltraumpirat
    weltraumpirat committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    9e20317 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Bugfix: Adding the click handler per useCustomElement() leads to a mu… 

    …ltiplication of handlers - one eventlistener is added per render pass - and thus, a single click will cause many actions, e.g. when a form is updated via onChange() on input elements.
    @weltraumpirat
    weltraumpirat committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0c445ac View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Bugfix: Adding the click handler per useCustomElement() leads to a mu… 

    …ltiplication of handlers - one eventlistener is added per render pass - and thus, a single click will cause many actions, e.g. when a form is updated via onChange() on input elements.
    @weltraumpirat
    weltraumpirat committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    c47b67a View commit details
    Browse the repository at this point in the history

  2. Bugfix: Adding value directly to the <wired-item> web component resul… 

    …ts in it being rendered correctly.
    @weltraumpirat
    weltraumpirat committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    0e25849 View commit details
    Browse the repository at this point in the history

  3. Bugfix: Adding selected directly to the <wired-listbox> web component… 

    … results in it being rendered correctly.
    @weltraumpirat
    weltraumpirat committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    59b1de3 View commit details
    Browse the repository at this point in the history

  4. Bugfix: ref.current sometimes returns null on page refresh - conditio… 

    …nal operator prevents undesired errors.
    @weltraumpirat
    weltraumpirat committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    245c0ad View commit details
    Browse the repository at this point in the history