fix(postgres): fix pg_isready issue with empty listen_addresses

[johnhampton]

This PR resolves the issue where pg_isready would fail when socketDir is set and listen_addresses is empty. pg_isready is now modified to use socketDir when it is available.

[srid]

Shoudn't this be done at a level close to the option def? Maybe:

services-flake/nix/postgres/default.nix

Lines 182 to 187 in e4d8770

	default = {
	listen_addresses = config.listen_addresses;
	port = config.port;
	unix_socket_directories = config.socketDir;
	hba_file = "${config.hbaConfFile}";
	};

(I haven't looked the whole code, so I might be missing something)

[shivaraj-bh]

Shoudn't this be done at a level close to the option def?

I doubt that is possible here, because then we would expect pg_isready to automatically detect, which amongst unix_socket_directories or listen_addresses to choose from based on postgresql.conf but don’t think that is supported: https://www.postgresql.org/docs/current/app-pg-isready.html

[shivaraj-bh]

@johnhampton could you also add a basic test services.postgres.”pg3”, that would test for empty listen_addresses and non-empty socketDir?

You can add the test here: https://github.com/juspay/services-flake/blob/main/nix/postgres/postgres_test.nix

[johnhampton]

@johnhampton could you also add a basic test services.postgres.”pg3”, that would test for empty listen_addresses and non-empty socketDir?

You can add the test here: https://github.com/juspay/services-flake/blob/main/nix/postgres/postgres_test.nix

@shivaraj-bh done.

[johnhampton]

Shoudn't this be done at a level close to the option def? Maybe:

@srid I'm not sure, I followed the code just above my change.

services-flake/nix/postgres/default.nix

Lines 317 to 322 in 0922b13

	${ if config.socketDir != "" then ''
	PGSOCKETDIR=$(readlink -f "${config.socketDir}")
	postgres -k "$PGSOCKETDIR"
	'' else ''
	postgres
	''}

[shivaraj-bh]

I doubt that is possible here, because then we would expect pg_isready to automatically detect, which amongst unix_socket_directories or listen_addresses to choose from based on postgresql.conf but don’t think that is supported: https://www.postgresql.org/docs/current/app-pg-isready.html

And primarily that is because the settings above (postgresql.conf) only applies to the server and not the client CLI utils.

I couldn’t find any documentation on the clients picking up configs from postgresql.conf, but did for the server: https://www.postgresql.org/docs/current/config-setting.html

[shivaraj-bh]

LGTM! Thanks