fix(mysql)!: look for *.sql files in the top-level schema directory
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
reviewed
Mar 18, 2024
* mysql service would assume that all the `*.sql` files in the directory,
provided by `initialDatabases [{ schema = <directory>; ... }]`, exists in a
folder named [mysql-databases](https://github.com/juspay/services-flake/blob/291e7be83aa0f24b8e40fc61df4a895827788707/nix/mysql.nix#L239-L241),
after this change it would just look for all the `*.sql` files in the top-level schema directory.
* add tests
shivaraj-bh
force-pushed
the
mysql-schema-dir
branch
from
6ab0a56
to
95def61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.sqlfiles in the directory, provided byinitialDatabases [{ schema = <directory>; ... }], exists in a folder named mysql-databases, after this change it would just look for all the*.sqlfiles in the top-level schema directory.