Skip to content

Add pre-commit-hooks.nix, enforcing conventional commits #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

shivaraj-bh
Copy link
Member

with treefmt and commitizen enabled

@shivaraj-bh shivaraj-bh requested a review from srid March 6, 2024 02:21
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are we okay with the default config?

I guess we can tweak the rules going forward.

@srid
Copy link
Member

srid commented Mar 6, 2024

These commits can be squashed into a single one, since this PR does one thing, basically.

@srid srid changed the title Add pre-commit-hooks.nix Add pre-commit-hooks.nix, enforcing conventional commits Mar 6, 2024
@srid
Copy link
Member

srid commented Mar 6, 2024

At some point, we should document our commit guidelines in https://community.flake.parts/services-flake/contributing

@srid srid mentioned this pull request Mar 6, 2024
enable treefmt and commitizen in pre-commit-hooks.nix

Along with this, we also:

* bump: update nixpkgs of dev flake for pre-commit-hooks.nix to work

the older version didn't have cljfmt
@shivaraj-bh shivaraj-bh merged commit 788ef28 into main Mar 6, 2024
@shivaraj-bh shivaraj-bh deleted the pre-commit-init branch March 6, 2024 16:59
@shivaraj-bh shivaraj-bh mentioned this pull request Mar 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants