chore: Enable Nix sandbox tests where applicable#432
chore: Enable Nix sandbox tests where applicable#432shivaraj-bh wants to merge 4 commits intomainfrom
Conversation
The clippy issue was on nightly. As of #427 we are no longer on nightly
| # FIXME: This should pass in the sandbox | ||
| # > ❄\u{fe0f} nix -j auto eval --json --override-input flake ../.. --override-input flake-schemas /nix/store/0npxvlidr0w1b99lrvcmd2wd46y2kibh-flake-schemas --override-input systems /nix/store/g1pv78p6lk92hjzr7syrcihvj4rx1fnz-source --no-write-lock-file \'/nix/store/qm8q4kylp1jy68k34c2bskpamxgyc9ix-source#contents.excludingOutputPaths\' --quiet --quiet\u{fe0f} | ||
| # > error: experimental Nix feature \'nix-command\' is disabled; use \'--extra-experimental-features nix-command\' to override | ||
| # > Error: Unable to fetch flake | ||
| "--skip=command::show::om_show_local" | ||
| ]); |
There was a problem hiding this comment.
@srid This could be a potential bug. I even tried looking at how om ci works, but even that uses the same NixCmd::Default, so it is likely that even om ci doesn’t automatically apply the experimental-features when not enabled by default.
We don’t have a similar om_ci_local test (that can run in Nix sandbox), which could be why it went undetected.
There was a problem hiding this comment.
EDIT: This happens on macOS only.
Is the error message in FIXME accurate? Because, when I allow om_show_local, it presents a different error message:
|
Thanks. I'd really prefer to have the clippy change on a commit of its own (either in this PR or different PR), so that the history remains clean for debugging issues in future. |
|
Moved clippy changes to #433 |
shivaraj-bh
changed the title
|
Note: once #433 is merged, we may be able to replace the |
srid
left a comment
srid
left a comment
There was a problem hiding this comment.
On second thought, I'm not sure if we should even bother to do this if several tests are being disabled anyway (for e.g., due to the fact that some "requires networking").
|
See also #397 We should run or the other, not both. If we can't run the full suite of tests in Nix, let's run tests outside of Nix only. |
2 participants
No description provided.