Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…ec/remove commands
Copilot
AI
changed the title
[WIP] Fix 'mcp test' to report correct server count
fix(cli): initialize MCP before listing servers in test/exec/remove commands
Nov 22, 2025
Contributor
|
Closing as part of project audit (2026-03-29). This PR contains useful patterns documented in the audit report, but is too stale or conflicting to merge directly. The valuable ideas will be applied manually where appropriate. See docs/project-audit-2026-03-29.md. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
mcp test,mcp exec, andmcp removecommands report 0 servers whilemcp listcorrectly loads servers from.mcp-config.json. Root cause:listMCPServers()doesn't trigger MCP initialization. OnlyexecuteList()callsgetMCPStatus()which internally invokesinitializeMCP()to load the config file.Type of Change
Related Issues
Changes Made
await sdk.getMCPStatus()beforesdk.listMCPServers()inexecuteTest()(line 705)await sdk.getMCPStatus()beforesdk.listMCPServers()inexecuteExec()(lines 820-821)await sdk.getMCPStatus()beforesdk.listMCPServers()inexecuteRemove()(lines 946-947)Before:
After:
AI Provider Impact
Component Impact
Testing
Test Environment
Performance Impact
Breaking Changes
None. Behavioral fix makes commands consistent with
mcp list.Screenshots/Demo
N/A
Checklist
Additional Notes
No test infrastructure exists for CLI commands. Comments added inline to document initialization requirement. CodeQL scan: 0 alerts. Code review: no issues.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node node install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/141.0.7390.54/linux64/chrome-linux64.zip/usr/local/bin/node node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.