feat(cli): improve provider status accuracy and error handling - #18
Merged
Merged
Conversation
This commit addresses a critical bug where the CLI was incorrectly reporting provider status due to the SDK's automatic fallback mechanism. The key changes include: - **Direct Provider Testing**: The `provider status` command now tests each provider directly, bypassing the SDK's fallback to provide accurate authentication status. - **Enhanced Ollama Check**: The Ollama status check now verifies both service availability and the presence of the required model. - **Improved Error Handling**: The Ollama provider now throws a clear, actionable error message when a model is not found. - **Circular Dependency Fix**: Resolved a `SyntaxError` in the `generate-text` command by refactoring the tool registry to use a singleton pattern. - **Documentation Updates**: Updated all relevant documentation to reflect the new provider status checks and error handling.
Contributor
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 of 5 tasks
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a critical bug where the CLI was incorrectly reporting provider status due to the SDK's automatic fallback mechanism. It also resolves a circular dependency issue that was causing a
SyntaxErrorin thegenerate-textcommand.Changes
provider statuscommand now tests each provider directly, bypassing the SDK's fallback to provide accurate authentication status.SyntaxErrorin thegenerate-textcommand by refactoring the tool registry to use a singleton pattern.Impact
generate-textcommand will now work correctly in all environments.