docs(providers): drop the last current-tense Vercel AI SDK claims - #1715
Conversation
Review follow-up on #1714. That PR corrected seven passages that described NeuroLink as running on the Vercel AI SDK; the reviewer pointed out that openai.md still contradicted its own new Overview a few hundred lines later, and named two more files the sweep had missed. Re-sweeping the hand-written docs surfaced three more of the same shape, so all six land together. Every line below claimed NeuroLink CURRENTLY runs on a package that is not in package.json, not in pnpm-lock.yaml, and imported nowhere in src/: - openai.md: streaming said it used the AI SDK's streamText/fullStream. It is NeuroLink's own HTTP+SSE client in openaiChatCompletionsBase.ts. - pdf-support.md: the processing flow formatted "as Vercel AI SDK file type". messageBuilder emits the provider's own file/document part. - reference/index.md: listed the AI SDK as "underlying provider implementations". It is a separate framework NeuroLink interoperates with through the client SDK's LanguageModelV1 adapter. - google-vertex.md: said the Gemini 3 native path "bypasses the Vercel AI SDK" because "the Vercel layer strips thoughtSignature" — present tense about a layer that no longer exists. The reason is restated as the token itself. - turn-time-budget.md: a section named after "the AI-SDK loop path". That path is the native loop. - provider-feature-compatibility.md: attributed Azure's rejection of the file content type to the AI SDK. The quoted error comes from the model API. Left alone deliberately: docs that reference the AI SDK as a separate thing — the client SDK's compatibility adapter, the observability guidance about spans your own app emits, the OpenCode proxy page, the migration guide, and the "all major frameworks do this" comparisons. Those are accurate. docs-site/static/search-index.json is regenerated, as the artifacts workflow requires.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request updates six documentation sections to describe native provider integrations, direct streaming, Gemini thought-signature preservation, PDF file parts, SDK interoperability, and Azure OpenAI API behavior. ChangesNative provider documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to These edits do not change runtime behavior and no concrete merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Single Commit Policy - COMPLIANTStatus: Policy requirements met • 1 commit • Valid format • Ready for merge 📊 View validation details📝 Commit Details
✅ Validation Results
🤖 Automated validation by NeuroLink Single Commit Enforcement |
Documentation Validation Results🚀 Documentation validation passed!
📦 Build artifact uploaded successfully. Ready for deployment preview. Commit: |
|
🎉 This PR is included in version 12.14.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
APPROVE — accurate, scoped, well-followed docs cleanupAll six edited passages were verified against source and are accurate; the regenerated
Thread resolutions from the prior round:
Verified accurate (no findings):
One suggested follow-up for a later docs pass: |
Tara-ag
left a comment
Tara-ag
left a comment
There was a problem hiding this comment.
Approving — accurate, scoped docs cleanup; all six claims verified against source and the regenerated search-index is current. Follow-ups noted in the summary comment.
2 participants
Review follow-up on the open thread from #1714 (
docs/getting-started/providers/openai.md).#1714 corrected seven passages that described NeuroLink as running on the Vercel AI SDK. The reviewer pointed out that
openai.mdstill contradicted its own new Overview a few hundred lines further down, and named two more files the sweep had missed. Re-sweeping the hand-written docs turned up three more of the same shape, so all six land here.Every line below asserted that NeuroLink currently runs on a package that is not in
package.json, not inpnpm-lock.yaml, and imported nowhere undersrc/.docs/getting-started/providers/openai.mdstreamTextwithfullStream"src/lib/providers/openaiChatCompletionsBase.tsdocs/features/pdf-support.mdmessageBuilderemits the provider's own file/document partdocs/reference/index.mdLanguageModelV1adapterdocs/getting-started/providers/google-vertex.mdthoughtSignature"docs/features/turn-time-budget.mddocs/reference/provider-feature-compatibility.mdfilecontent type attributed to the AI SDKDeliberately left alone
These reference the Vercel AI SDK as a separate thing, which is accurate, and would be wrong to remove:
docs/features/client-sdk.md+docs/features/index.md— the client SDK really does ship aLanguageModelV1compatibility adapter (src/lib/client/aiSdkAdapter.ts).docs/features/observability.md— about spans your application emits; the page already states NeuroLink has no dependency onai.docs/features/opencode-proxy-support.md— about OpenCode, which does use it.docs/guides/index.md,docs/guides/frameworks/nextjs.md— a migration guide and an "alternative SDK" link.docs/features/structured-output.md,google-ai.md,google-vertex.md:977,troubleshooting.md— "all major frameworks do this" comparisons.docs/advanced/builtin-middleware.md— already says NeuroLink no longer depends on it.docs/analysis/**,docs/features/claude-subscription-testing.md— historical records, already marked as such by docs(providers): describe the native provider layer instead of the removed ai-sdk #1714.Testing
Documentation only; no source, no behaviour.
prettier --checkon all six files: clean, no reformatting needed.docs-siterebuilt;docs-site/static/search-index.jsonregenerated and committed, asdocs-site-artifacts.ymlrequires.[search-index] Generated 14356 entries from 3945 files.Summary by CodeRabbit