fix(proxy): align update check status field by murdore · Pull Request #1312 · juspay/neurolink

murdore · 2026-08-11T04:48:46Z

Summary

rename the status-only lastUpdateCheckAt field to lastCheckAt
align CLI JSON terminology with persisted updater state and existing status API terminology
preserve the text output and all updater/proxy behavior

Verification

pnpm exec prettier --check src/cli/commands/proxy.ts
pnpm exec eslint src/cli/commands/proxy.ts (0 errors; existing file-length warnings only)
pnpm exec tsc --noEmit --project tsconfig.cli.json
read-only local-source proxy status invocation
git diff --check

Summary by CodeRabbit

Bug Fixes
- Updated the proxy status output to use the correct latest check timestamp label.

github-actions · 2026-08-11T04:49:05Z

✅ Single Commit Policy - COMPLIANT

Status: Policy requirements met • 1 commit • Valid format • Ready for merge

📊 View validation details

📝 Commit Details

Hash: 3e6aeab75cbab416c49c1340e412e1d04dfb7a59
Message: fix(proxy): align update check status field
Author: Sachin Sharma

✅ Validation Results

Single commit requirement met
No merge commits in branch
Semantic commit message format verified
Ready for squash merge to release branch

🤖 Automated validation by NeuroLink Single Commit Enforcement

coderabbitai · 2026-08-11T04:49:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fce801fb-5a84-4665-89bc-4e583de9414a

📥 Commits

Reviewing files that changed from the base of the PR and between 9096b8f and e4b95ab.

📒 Files selected for processing (1)

src/cli/commands/proxy.ts

📝 Walkthrough

Walkthrough

The proxy status timestamp field was renamed from lastUpdateCheckAt to lastCheckAt. The status text output now reads the renamed field.

Changes

Proxy status reporting

Layer / File(s)	Summary
Rename proxy status timestamp field `src/cli/commands/proxy.ts`	The status object and status display now use `lastCheckAt` for the latest check time.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

juspay/neurolink#1264: Both changes update proxy status and update-check reporting in src/cli/commands/proxy.ts.
juspay/neurolink#1311: This PR renames the same proxy status timestamp field from lastUpdateCheckAt to lastCheckAt.

Suggested reviewers: pdogra1299

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the proxy status field alignment, which matches the main change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/proxy-status-check-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-11T04:50:42Z

🤖 AI Review & Build Compliance ✅

Status: AI analysis complete • Build rules validated • Ready for review

📊 View detailed analysis results

🛡️ Analysis Complete

✅ Security scan (vulnerabilities, API keys)
✅ TypeScript safety & code quality
✅ Error handling & best practices
✅ Build rule enforcement validated
✅ Commit format & compliance checks

📋 Ready for Merge When

All CI checks passing
Manual review approved
Any AI-flagged issues resolved

🤖 AI analysis complete - check individual code comments for specific feedback

Copilot

Pull request overview

This PR adjusts the neurolink proxy status command’s JSON schema to align the “update check” timestamp field name with the persisted UpdateState (lastCheckAt) and the proxy /status API’s terminology, while keeping the human-readable text output the same.

Changes:

Renames the JSON status field from lastUpdateCheckAt to lastCheckAt.
Updates the text-rendering path to read the renamed field when printing “Last update check”.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Tara-ag · 2026-08-12T02:21:01Z

        latestVersion: updateState?.lastCheckVersion || null,
        lastDetectedVersion: updateState?.lastCheckVersion || null,
-        lastUpdateCheckAt: updateState?.lastCheckAt ?? null,
+        lastCheckAt: updateState?.lastCheckAt ?? null,
        installedVersion:


This is actually a MINOR suggestion rather than a blocking issue. While the JSON field name does change, this aligns the implementation with:

The canonical field name in UpdateState type (updateState.lastCheckAt)

The source data structure (the actual update check timestamp is stored as lastCheckAt, not lastUpdateCheckAt)

The rename makes the JSON output consistent with what's actually persisted and queried from the database. For backward compatibility concerns, we could consider:

Adding both fields temporarily (but this adds unnecessary complexity)

Documenting this as a schema evolution in release notes

Since this is a CLI command that's part of the maintenance workflow (not a user-facing API), the impact is minimal. Users who parse the JSON can update their scripts - this is standard practice for any service updating its output format.

github-actions · 2026-08-12T02:16:20Z

🤖 AI Review & Build Compliance ✅

Status: AI analysis complete • Build rules validated • Ready for review

📊 View detailed analysis results

🛡️ Analysis Complete

✅ Security scan (vulnerabilities, API keys)
✅ TypeScript safety & code quality
✅ Error handling & best practices
✅ Build rule enforcement validated
✅ Commit format & compliance checks

📋 Ready for Merge When

All CI checks passing
Manual review approved
Any AI-flagged issues resolved

🤖 AI analysis complete - check individual code comments for specific feedback

Tara-ag · 2026-08-12T02:22:19Z

Review Summary

Decision: APPROVED ✅

This PR is a simple, low-risk refactoring that improves code consistency without any functional impact.

Findings (1 total)

Severity	Category	Issue	Location
💬 SUGGESTION	Code Quality	Property naming inconsistency resolved	`src/cli/commands/proxy.ts`:3816

Details: The PR renames lastUpdateCheckAt to lastCheckAt, aligning the implementation with the canonical field name updateState.lastCheckAt used throughout the data structure. This change improves consistency by using the same field name as the source data. No functional impact.

Impact Analysis

Files Changed: 1 file (src/cli/commands/proxy.ts)
Lines Changed: 6 lines (3 additions, 3 deletions)
Breaking Changes: None
API Impact: None - this is an internal property rename only
Test Impact: No tests were found that specifically test the proxyStatusCommand, so no test updates required

Review Scope

This was a single-file review focusing on:

Code correctness and consistency
Alignment with type definitions
Potential breaking changes
Test coverage

Conclusion

The change is safe to merge. It's a straightforward property rename that makes the implementation consistent with its data source (updateState.lastCheckAt). No behavioral changes, no API breaking changes, and no downstream impact expected.

Reviewed following NeuroLink project standards, including CLAUDE.md Critical Rules for backward compatibility and type safety.

Tara-ag · 2026-08-12T02:22:03Z

@@ -3816,7 +3816,7 @@ export const proxyStatusCommand: CommandModule<object, ProxyStatusArgs> = {
        updaterRunning: false,


💬 SUGGESTION: Property naming inconsistency resolved - The PR renames lastUpdateCheckAt to lastCheckAt, aligning the implementation with the canonical field name updateState.lastCheckAt used throughout the data structure. This change improves consistency by using the same field name as the source data. No functional impact.

github-actions · 2026-08-12T02:23:17Z

🎉 This PR is included in version 10.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copilot AI lite review requested due to automatic review settings August 11, 2026 04:48

murdore mentioned this pull request Aug 11, 2026

fix(proxy): show update check timestamp in status #1311

Merged

Copilot started reviewing on behalf of murdore August 11, 2026 04:49 View session

Copilot AI reviewed Aug 11, 2026

View reviewed changes

fix(proxy): align update check status field

3e6aeab

murdore force-pushed the fix/proxy-status-check-field branch from e4b95ab to 3e6aeab Compare August 12, 2026 02:14

murdore merged commit 1679891 into release Aug 12, 2026
12 of 13 checks passed

murdore deleted the fix/proxy-status-check-field branch August 12, 2026 02:14

Tara-ag approved these changes Aug 12, 2026

View reviewed changes

github-actions Bot added the released label Aug 12, 2026

		@@ -3816,7 +3816,7 @@ export const proxyStatusCommand: CommandModule<object, ProxyStatusArgs> = {
		updaterRunning: false,

Conversation

murdore commented Aug 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Single Commit Policy - COMPLIANT

📝 Commit Details

✅ Validation Results

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 11, 2026

🤖 AI Review & Build Compliance ✅

🛡️ Analysis Complete

📋 Ready for Merge When

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Tara-ag Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026

🤖 AI Review & Build Compliance ✅

🛡️ Analysis Complete

📋 Ready for Merge When

Uh oh!

Tara-ag commented Aug 12, 2026

Review Summary

Decision: APPROVED ✅

Findings (1 total)

Impact Analysis

Review Scope

Conclusion

Uh oh!

Tara-ag Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

murdore commented Aug 11, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading