Skip to content

feat(proxy): comprehensive proxy support for all AI providers #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murdore merged 1 commit into from
Aug 25, 2025
Merged

feat(proxy): comprehensive proxy support for all AI providers #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/mcp/toolDiscoveryService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,10 +737,12 @@ export class ToolDiscoveryService extends EventEmitter {
// GENERIC ERROR HANDLING FOR ALL MCP TOOLS
// Different MCP servers return different error formats, so we should be permissive
// and let the AI handle any response format instead of throwing errors

// Only throw for truly invalid responses (null/undefined)
if (isNullish(result)) {
mcpLogger.debug("[ToolDiscoveryService] Tool returned null/undefined, treating as empty response");
mcpLogger.debug(
"[ToolDiscoveryService] Tool returned null/undefined, treating as empty response",
);
// Even null responses can be valid for some tools - don't throw
return;
}
Expand All @@ -751,15 +753,15 @@ export class ToolDiscoveryService extends EventEmitter {
isArray: Array.isArray(result),
isObject: isObject(result),
hasKeys: isObject(result) ? Object.keys(result as object).length : 0,
fullResponse: result // Log the complete response, not a truncated sample
fullResponse: result, // Log the complete response, not a truncated sample
});

// COMPLETELY PERMISSIVE APPROACH:
// - Any response format is valid (objects, strings, arrays, booleans, numbers)
// - Even error responses are passed to the AI to handle
// - The AI can interpret error messages and retry with different approaches
// - This works with any MCP server regardless of their response format

// No validation or throwing - let the AI handle everything
return;
}
Expand Down
Loading
Loading