fix: close upstream LLM stream on client disconnect (port #30245) - #184
Merged
prakhar-prakash-juspay merged 1 commit intoJun 15, 2026
Merged
Conversation
On client disconnect mid-stream, Starlette abandons the response body iterator without calling aclose(), leaving the upstream vLLM connection open and the GPU slot held until GC (zombie streams -> pool/slot starvation -> 540s timeouts under load). Wrap the streaming response so its __call__ finally force-closes both the body iterator and the upstream generator, triggering the existing response.aclose() cleanup; add BaseModelResponseIterator.aclose()/http_response so the close reaches the live connection. Both proxy streaming paths (/chat/completions and /v1/messages) are covered via create_response. Ports BerriAI#30245. Verified: 92 tests pass; ruff clean; black-clean on added lines. Co-authored-by: Claude <noreply@anthropic.com>
shriharsha98
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On client disconnect mid-stream, Starlette abandons the response body iterator without calling aclose(), leaving the upstream vLLM connection open and the GPU slot held until GC (zombie streams -> pool/slot starvation -> 540s timeouts under load).
Wrap the streaming response so its call finally force-closes both the body iterator and the upstream generator, triggering the existing response.aclose() cleanup; add BaseModelResponseIterator.aclose()/http_response so the close reaches the live connection. Both proxy streaming paths (/chat/completions and /v1/messages) are covered via create_response.
Ports BerriAI#30245. Verified: 92 tests pass; ruff clean; black-clean on added lines.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes