-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(connector): [Barclaycard] Implement Cards - Non 3DS flow #8068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
deepanshu-iiitu
requested changes
May 21, 2025
Comment on lines
789
to
808
let connector_payment_id = req.request.connector_transaction_id.clone(); | ||
match req.request.capture_method { | ||
Some(enums::CaptureMethod::Automatic) | ||
| Some(enums::CaptureMethod::SequentialAutomatic) => Ok(format!( | ||
"{}pts/v2/payments/{connector_payment_id}/refunds", | ||
self.base_url(connectors) | ||
)), | ||
Some(enums::CaptureMethod::Manual) => Ok(format!( | ||
"{}pts/v2/captures/{connector_payment_id}/refunds", | ||
self.base_url(connectors) | ||
)), | ||
Some(enums::CaptureMethod::ManualMultiple) | ||
| Some(enums::CaptureMethod::Scheduled) | ||
| None => Err(utils::construct_not_implemented_error_report( | ||
req.request | ||
.capture_method | ||
.unwrap_or(enums::CaptureMethod::ManualMultiple), | ||
self.id(), | ||
)), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test that if /payments works for both, if yes remove /captures
deepanshu-iiitu
previously approved these changes
May 22, 2025
Chethan-rao
previously approved these changes
May 22, 2025
dd96851
Chethan-rao
approved these changes
May 23, 2025
deepanshu-iiitu
approved these changes
May 23, 2025
pixincreate
added a commit
that referenced
this pull request
May 30, 2025
…ordea-sepa * 'main' of github.com:juspay/hyperswitch: (30 commits) chore(version): 2025.05.30.0 chore(ci): update postman ci credentials (#8172) chore(docs): remove old add_connector.md file (#8143) refactor: Payment Attempt as mandatory field in PaymentStatusData (#8126) fix(payment_link): sanitize embedded payment link data (#7736) chore(version): 2025.05.29.0 feat(analytics): Add ckh columns for 3ds intelligence analytics (#8136) refactor(debit_routing): Handle missing merchant_business_country by defaulting to US (#8141) chore(version): 2025.05.28.0 refactor(success_based): add support for exploration (#8158) feat(dynamic_routing): add get api for dynamic routing volume split (#8114) fix: incorrect payout_method_id in payouts table (#8107) feat(router): Enable client_secret auth for payments_get_intent [v2] (#8119) chore: address Rust 1.87.0 clippy lints (#8130) feat: list for dynamic routing (#8111) ci(cypress): fix mandates unsupported connectors (#8086) feat(connector): [Barclaycard] Implement Cards - Non 3DS flow (#8068) fix(authentication): add Organization context validation in `Merchant Create` and `Merchant List` APIs (#8103) feat(connector): [Worldpayxml] add card payment (#8076) feat(connector): Stripe revolut pay wallet integration (#8066) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Closes this issue
Description
Added Authorize, Capture, Void, Refund, PSync and RSync flow for cards payment method for Barclaycard. Also added connector specifications for the same connector.
Additional Changes
Motivation and Context
How did you test it?
Postman Tests
Request:
Response:
Request:
Response:
Request:
Response:
Request:
Response:
Request:
Response:
Request:
Response:
Checklist
cargo +nightly fmt --all
cargo clippy