Skip to content

feat(connector): [DATATRANS] Add Support for External 3DS #7226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2025
Merged

feat(connector): [DATATRANS] Add Support for External 3DS #7226

merged 5 commits into from
Feb 9, 2025

Conversation

awasthi21
Copy link
Contributor

@awasthi21 awasthi21 commented Feb 8, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added Support for External 3DS

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Not able to test it on Local. Testing will be on integ.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@awasthi21 awasthi21 self-assigned this Feb 8, 2025
@awasthi21 awasthi21 requested a review from a team as a code owner February 8, 2025 10:56
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/common_enums/src/connector_enums.rs  42% smaller
  crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs  20% smaller
  crates/hyperswitch_connectors/src/connectors/datatrans.rs  3% smaller

deepanshu-iiitu
deepanshu-iiitu requested changes Feb 9, 2025
View reviewed changes
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Feb 9, 2025
View reviewed changes
AkshayaFoiger
AkshayaFoiger previously approved these changes Feb 9, 2025
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit 45882bd Feb 9, 2025
17 of 20 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 3ds-external-auth-datatrans branch February 9, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@deepanshu-iiitu deepanshu-iiitu Awaiting requested review from deepanshu-iiitu

Assignees

@awasthi21 awasthi21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awasthi21 @deepanshu-iiitu @swangi-kumari @AkshayaFoiger @Gnanasundari24