fix: consider status of payment method before filtering wallets in list pm

[Chethan-rao]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

#3953
We were not considering the status of payment method in above filtering logic

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

1. Create merchant_account, api_key, mca (with any wallet)
2. Create a payment with wallet as payment method with authentication_type as three_ds. Retain the status of payment as processing

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_qVglrYUpCaoLCvnixZd3hX0ls7du5ZmaVMhZJNGt8ezEN4Axn8oU22i2gRz0OTqx' \
--data '{
    "amount": 6540,
    "confirm": true,
    "currency": "USD",
    "customer_acceptance": {
        "acceptance_type": "online"
    },
    "customer_id": "cus_kWEMsP0NufHyhHsBB1Ol",
    "profile_id": "pro_mjcaEelE0mjdp8ODpfkc",
    "authentication_type": "three_ds",
    "payment_method": "wallet",
    "payment_method_type": "apple_pay",
    "payment_method_data": {
        "wallet": {
            "apple_pay": {
                "payment_data": "token",
                "payment_method": {
                    "display_name": "Visa 0326",
                    "network": "Mastercard",
                    "type": "debit"
                },
                "transaction_identifier": "55CC32D7BF7890B9064433F15B9F23F849CF84AFD01E4E65DD8ADE306300E9D8"
            }
        }
    }
}'

3. Create another payment with confirm:false

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_qVglrYUpCaoLCvnixZd3hX0ls7du5ZmaVMhZJNGt8ezEN4Axn8oU22i2gRz0OTqx' \
--data '{
    "amount": 6540,
    "confirm": false,
    "currency": "USD",
    "customer_acceptance": {
        "acceptance_type": "online"
    },
    "customer_id": "cus_kWEMsP0NufHyhHsBB1Ol",
    "profile_id": "pro_mjcaEelE0mjdp8ODpfkc",
    "authentication_type": "three_ds"
}'

4. list merchant pml. When the status of payment_method is inactive in db, the wallet should appear in the list

curl --location 'http://localhost:8080/account/payment_methods?client_secret=pay_Fvjj9zQjd2BA47M6qFJO_secret_gV3eKHcXxHT9PdA7fBbk' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_c079bd1ada67401fb98568ea6f6043bf' \
--data '' "

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payment_methods/cards.rs	66% smaller