-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(connector): add config cleanup on payment connector deletion #5998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
likhinbopanna
merged 7 commits into
juspay:main
from
noagbmn:fix_delete_merchant_connector_account_from_config
Dec 6, 2024
Merged
fix(connector): add config cleanup on payment connector deletion #5998
likhinbopanna
merged 7 commits into
juspay:main
from
noagbmn:fix_delete_merchant_connector_account_from_config
Dec 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
@SanchithHegde Hi, is this PR going to get reviewed? The issue also didn't get labeled |
Aprabhat19
requested changes
Oct 1, 2024
@Aprabhat19 Hi again! Re-requested your review |
Aprabhat19
previously approved these changes
Oct 8, 2024
@SanchithHegde Hi sorry can we get a second reviewer? |
SanchithHegde
previously approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the contribution, and apologies for the delay!
817dc6a
817dc6a
to
0c4b1bd
Compare
SanchithHegde
approved these changes
Dec 3, 2024
Aprabhat19
approved these changes
Dec 4, 2024
Narayanbhat166
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes #5966 (in both v1 and v2). Now the router cleans up the configs table (or business_profile in v2) when a connector is deleted.
Additional Changes
Motivation and Context
How did you test it?
Added a payment and payout processor, checked if values are present in config, deleted and rechecked.

v1:
v2:

Test on Integ
Checklist
cargo +nightly fmt --all
cargo clippy