Skip to content

refactor(customer_v2): fixed customer_v2 create panic issue #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2024
Merged

refactor(customer_v2): fixed customer_v2 create panic issue #5699

merged 5 commits into from
Aug 28, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Aug 26, 2024 •
edited
Loading

Type of Change

  • Refactoring

Description

Currently we are not able to create customer for customer_v2 since it panics in todo!() functions, with this pr we will be able to create customer for v2.

How did you test it?

Postman test cases

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sahkal sahkal added A-core Area: Core flows C-refactor Category: Refactor api-v2 labels Aug 26, 2024
@sahkal sahkal added this to the August 2024 Release milestone Aug 26, 2024
@sahkal sahkal self-assigned this Aug 26, 2024
@sahkal sahkal requested review from a team as code owners August 26, 2024 12:11
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 26, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 23 of 24 files.

Overall, the semantic diff is 9% smaller than the GitHub diff.

File Information
Filename Status
✔️ crates/router/src/types/transformers.rs 5.44% smaller
✔️ crates/router/src/types/api/customers.rs 18.53% smaller
✔️ crates/router/src/db/customers.rs Analyzed
✔️ crates/router/src/core/payment_methods.rs 79.47% smaller
✔️ crates/router/src/core/payout_link.rs 79.54% smaller
✔️ crates/router/src/core/payouts.rs 0.0% smaller
✔️ crates/router/src/core/utils.rs 8.63% smaller
✔️ crates/router/src/core/payouts/helpers.rs Analyzed
✔️ crates/router/src/core/payouts/transformers.rs 13.9% smaller
✔️ crates/router/src/core/payouts/validator.rs 3.44% smaller
❔ crates/router/src/core/payments/flows.rs Unsupported file format
✔️ crates/router/src/core/payments/transformers.rs 4.7% smaller
✔️ crates/router/src/core/payments/operations/payment_complete_authorize.rs 66.88% smaller
✔️ crates/router/src/core/payments/operations/payment_confirm.rs Analyzed
✔️ crates/router/src/core/payments/operations/payment_create.rs Analyzed
✔️ crates/router/src/core/payments/operations/payment_update.rs 1.57% smaller
✔️ crates/router/src/core/payment_methods/cards.rs Analyzed
✔️ crates/router/src/core/fraud_check/operation/fraud_check_pre.rs Analyzed
✔️ crates/router/src/core/fraud_check/flows/checkout_flow.rs 20.49% smaller
✔️ crates/router/src/core/fraud_check/flows/record_return.rs 20.49% smaller
✔️ crates/router/src/core/fraud_check/flows/sale_flow.rs 21.63% smaller
✔️ crates/router/src/core/fraud_check/flows/transaction_flow.rs 19.46% smaller
✔️ crates/hyperswitch_domain_models/src/customer.rs Analyzed
✔️ crates/diesel_models/src/kv.rs 79.47% smaller

@sahkal sahkal removed the request for review from Narayanbhat166 August 27, 2024 12:20
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit c555a88 Aug 28, 2024
18 checks passed
@likhinbopanna likhinbopanna deleted the 6468-customer-v2-make-customer-create-v2-endpoint-work branch August 28, 2024 08:37
pixincreate added a commit that referenced this pull request Aug 28, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-auto-retry
b8c2faf 
* 'main' of github.com:juspay/hyperswitch:
  feat(connector): [FISERVEMEA] Integrate cards (#5672)
  ci(cypress): Add routing testcases (#5571)
  fix(router): skip external three_ds flow for recurring payments (#5730)
  refactor(customer_v2): fixed customer_v2 create panic issue (#5699)
  feat(user_roles): support switch for new hierarchy (#5692)
  refactor(router): add domain type for merchant_connector_account id (#5685)
  refactor(cypress_tests): handle api keys check in api key list call (#5719)
  feat(connector): [NEXIXPAY] Add template code (#5684)
  refactor(connector): [itau] refactor error reason and code mapping for itau (#5718)
  fix(core): fix merchant connector account create for v2  (#5716)
  chore(version): 2024.08.28.0
  fix(routing): fix routing routes to deserialise correctly (#5724)
  feat(euclid): add a new variant in payment type i.e ppt_mandate (#5681)
  feat(core): Add mTLS certificates for each request (#5636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

Assignees

@sahkal sahkal

Labels
A-core Area: Core flows api-v2 C-refactor Category: Refactor
Projects
None yet
Milestone
August 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sahkal @jarnura @prajjwalkumar17 @likhinbopanna