fix(pm_auth): Added mca status check in pml #5421

Sarthak1799 · 2024-07-23T14:01:03Z

Type of Change

Description

Added a check in mca for pm_auth_connectors to include only the active ones.
If a Pm auth connector is disabled, it should not show up in the pm_auth_connector field in PML response

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Deactivate the pm_auth account -

curl --location --request POST 'http://localhost:8080/account/merchant_1721742760/connectors/mca_r7PzL0AWF5tHJ8sUWqIG' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data-raw '{
  "connector_type": "payment_method_auth",
  "status": "inactive",
  "metadata": {
    "city": "NY",
    "unit": "245"
  }
}'

Call PML for merchant

curl --location --request GET 'http://localhost:8080/account/payment_methods?client_secret=pay_zj0McWhRpiXD0LHDLUmf_secret_59U5b2KF3XTaYnkVCkh5' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_96d5dd30db4542d9bb0135c05abf79f3' \
--data-raw ''

Resposne

{
    "redirect_url": "https://google.com/success",
    "currency": "USD",
    "payment_methods": [
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "payment_method_type": "klarna",
                    "payment_experience": [
                        {
                            "payment_experience_type": "redirect_to_url",
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {
                        "email": {
                            "required_field": "email",
                            "display_name": "email",
                            "field_type": "user_email_address",
                            "value": "[email protected]"
                        },
                        "payment_method_data.pay_later.klarna.billing_country": {
                            "required_field": "payment_method_data.pay_later.klarna.billing_country",
                            "display_name": "billing_country",
                            "field_type": {
                                "user_address_country": {
                                    "options": [
                                        "ALL"
                                    ]
                                }
                            },
                            "value": null
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "afterpay_clearpay",
                    "payment_experience": [
                        {
                            "payment_experience_type": "redirect_to_url",
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {
                        "payment_method_data.pay_later.afterpay_clearpay_redirect.billing_email": {
                            "required_field": "payment_method_data.pay_later.afterpay_clearpay_redirect.billing_email",
                            "display_name": "billing_email",
                            "field_type": "user_email_address",
                            "value": null
                        },
                        "name": {
                            "required_field": "name",
                            "display_name": "cust_name",
                            "field_type": "user_full_name",
                            "value": "John Doe"
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "affirm",
                    "payment_experience": [
                        {
                            "payment_experience_type": "redirect_to_url",
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {},
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        },
        {
            "payment_method": "bank_transfer",
            "payment_method_types": [
                {
                    "payment_method_type": "ach",
                    "payment_experience": [
                        {
                            "payment_experience_type": "redirect_to_url",
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {},
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "sepa",
                    "payment_experience": [
                        {
                            "payment_experience_type": "redirect_to_url",
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": null,
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "debit",
                    "payment_experience": null,
                    "card_networks": [
                        {
                            "card_network": "Visa",
                            "surcharge_details": null,
                            "eligible_connectors": [
                                "stripe"
                            ]
                        },
                        {
                            "card_network": "Mastercard",
                            "surcharge_details": null,
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {
                        "payment_method_data.card.card_exp_month": {
                            "required_field": "payment_method_data.card.card_exp_month",
                            "display_name": "card_exp_month",
                            "field_type": "user_card_expiry_month",
                            "value": null
                        },
                        "payment_method_data.card.card_number": {
                            "required_field": "payment_method_data.card.card_number",
                            "display_name": "card_number",
                            "field_type": "user_card_number",
                            "value": null
                        },
                        "payment_method_data.card.card_exp_year": {
                            "required_field": "payment_method_data.card.card_exp_year",
                            "display_name": "card_exp_year",
                            "field_type": "user_card_expiry_year",
                            "value": null
                        },
                        "payment_method_data.card.card_cvc": {
                            "required_field": "payment_method_data.card.card_cvc",
                            "display_name": "card_cvc",
                            "field_type": "user_card_cvc",
                            "value": null
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "credit",
                    "payment_experience": null,
                    "card_networks": [
                        {
                            "card_network": "Mastercard",
                            "surcharge_details": null,
                            "eligible_connectors": [
                                "stripe"
                            ]
                        },
                        {
                            "card_network": "Visa",
                            "surcharge_details": null,
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ],
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "required_fields": {
                        "payment_method_data.card.card_cvc": {
                            "required_field": "payment_method_data.card.card_cvc",
                            "display_name": "card_cvc",
                            "field_type": "user_card_cvc",
                            "value": null
                        },
                        "payment_method_data.card.card_number": {
                            "required_field": "payment_method_data.card.card_number",
                            "display_name": "card_number",
                            "field_type": "user_card_number",
                            "value": null
                        },
                        "payment_method_data.card.card_exp_month": {
                            "required_field": "payment_method_data.card.card_exp_month",
                            "display_name": "card_exp_month",
                            "field_type": "user_card_expiry_month",
                            "value": null
                        },
                        "payment_method_data.card.card_exp_year": {
                            "required_field": "payment_method_data.card.card_exp_year",
                            "display_name": "card_exp_year",
                            "field_type": "user_card_expiry_year",
                            "value": null
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        },
        {
            "payment_method": "bank_debit",
            "payment_method_types": [
                {
                    "payment_method_type": "ach",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "bank_transfers": null,
                    "required_fields": {
                        "billing.address.first_name": {
                            "required_field": "payment_method_data.billing.address.first_name",
                            "display_name": "billing_first_name",
                            "field_type": "user_billing_name",
                            "value": "joseph"
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "sepa",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "bank_transfers": null,
                    "required_fields": {
                        "billing.address.first_name": {
                            "required_field": "payment_method_data.billing.address.first_name",
                            "display_name": "billing_first_name",
                            "field_type": "user_billing_name",
                            "value": "joseph"
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "bacs",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "bank_transfers": null,
                    "required_fields": {
                        "billing.address.first_name": {
                            "required_field": "payment_method_data.billing.address.first_name",
                            "display_name": "billing_first_name",
                            "field_type": "user_billing_name",
                            "value": "joseph"
                        }
                    },
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        },
        {
            "payment_method": "bank_transfer",
            "payment_method_types": [
                {
                    "payment_method_type": "ach",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "required_fields": {},
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "sepa",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "required_fields": null,
                    "surcharge_details": null,
                    "pm_auth_connector": null
                },
                {
                    "payment_method_type": "bacs",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": {
                        "eligible_connectors": [
                            "stripe"
                        ]
                    },
                    "required_fields": null,
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        }
    ],
    "mandate_payment": null,
    "merchant_name": "Sarthak1",
    "show_surcharge_breakup_screen": false,
    "payment_type": "normal",
    "request_external_three_ds_authentication": false,
    "collect_shipping_details_from_wallets": false,
    "collect_billing_details_from_wallets": false
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

crates/router/src/core/payment_methods/cards.rs

…ypress-x2 * 'main' of github.com:juspay/hyperswitch: refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488)

* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...

fix(pm_auth): Added mca status check in pml

ac97c44

Sarthak1799 added C-bug Category: Bug A-payment-methods Area: Payment Methods labels Jul 23, 2024

Sarthak1799 self-assigned this Jul 23, 2024

Sarthak1799 requested a review from a team as a code owner July 23, 2024 14:01

Sarthak1799 linked an issue Jul 23, 2024 that may be closed by this pull request

[FEATURE] Fixes in PM Auth #5422

Closed

2 tasks

Merge branch 'main' into pm-auth-mca-fix

c7a2dea

Chethan-rao suggested changes Jul 24, 2024

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved

Sarthak1799 and others added 3 commits July 25, 2024 00:42

fix(pm_auth): Resolved comments

79d2e5d

Merge branch 'main' into pm-auth-mca-fix

98caf27

fix(pm_auth): Fixed errors

d11227e

Chethan-rao previously approved these changes Jul 25, 2024

View reviewed changes

vspecky suggested changes Jul 26, 2024

View reviewed changes

crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved

fix(pm_auth): Resolved comments

d09a228

Sarthak1799 dismissed Chethan-rao’s stale review via d09a228 July 26, 2024 13:03

vspecky approved these changes Aug 2, 2024

View reviewed changes

Chethan-rao approved these changes Aug 2, 2024

View reviewed changes

likhinbopanna added this pull request to the merge queue Aug 2, 2024

Merged via the queue into main with commit e9bd345 Aug 2, 2024

likhinbopanna deleted the pm-auth-mca-fix branch August 2, 2024 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(pm_auth): Added mca status check in pml #5421

fix(pm_auth): Added mca status check in pml #5421

Uh oh!

Sarthak1799 commented Jul 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(pm_auth): Added mca status check in pml #5421

fix(pm_auth): Added mca status check in pml #5421

Uh oh!

Conversation

Sarthak1799 commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sarthak1799 commented Jul 23, 2024 •

edited

Loading