refactor(user_roles): make org and merchant id nullable #5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-database-changes
…e-org-merchant-id-nullable-user-role
…e-org-merchant-id-nullable-user-role
…e-org-merchant-id-nullable-user-role
jarnura
requested changes
Jul 24, 2024
| ALTER TABLE user_roles ALTER COLUMN org_id DROP NOT NULL; | ||
| ALTER TABLE user_roles ALTER COLUMN merchant_id DROP NOT NULL; | ||
|
|
||
| ALTER TABLE user_roles ADD COLUMN profile_id VARCHAR(255); |
There was a problem hiding this comment.
Make profile_id,entity_id as varchar(64)
jarnura
previously approved these changes
Jul 24, 2024
racnan
previously approved these changes
Jul 24, 2024
…e-org-merchant-id-nullable-user-role
…e-org-merchant-id-nullable-user-role
racnan
approved these changes
Jul 25, 2024
jarnura
approved these changes
Jul 25, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 30, 2024
* 'main' of github.com:juspay/hyperswitch: refactor(router): remove `connector_account_details` and `connector_webhook_details` in merchant_connector_account list response (#5457) feat: add env variable for enable key manager service (#5442) chore(version): 2024.07.29.0 feat(payments): support sort criteria in payments list (#5389) refactor(connector): add amount conversion framework to placetopay (#4988) feat(connector): [Bambora APAC] add mandate flow (#5376) ci: set code owners for payment methods files (#5453) refactor(opensearch): Add Error Handling for Empty Query and Filters in Request (#5432) chore: address Rust 1.80 clippy lints (#5447) feat(connector): [FISERV] Move connector to hyperswitch_connectors (#5441) ci: add support for just hack_v2 check for PRs (#5426) fix: added created at and modified at keys in PaymentAttemptResponse (#5412) refactor(merchant_account_v2): recreate id for `merchant_account` v2 (#5439) chore(version): 2024.07.26.0 feat(events): forward the tenant configuration as part of the kafka message (#5224) refactor(connector): add amount conversion framework to payone (#4981) refactor(user_roles): make org and merchant id nullable (#5353) fix(euclid): change the address taken in SessionFlowRouting from shipping to billing address (#5435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
DB changes in user_roles
versionentity_identity_typeprofile_idmerchant_idis now nullableorg_idis now nullableAdditional Changes
Motivation and Context
Closes #5352
How did you test it?
All these APIs should work without giving 500.
User - Signup w/ merchant id
User - Signin
User - Signin Token Only
User - Connect Account
User - Reset Password
User - Invite Multiple
User - Resend Invite
User - Accept Invite from Mail
User - Accept Invite from Mail Token only
User - Switch Merchant
User - Switch List
User - Merchants List
User - Merchants Select List
User - List
User - Verify Email
User - Verify Email Token only
User - Update User details
User Role - Update
User Role - Transfer Ownership
User Role - Accept Invite - POST
User Role - Accept Invite - PUT
User Role - Delete
Checklist
cargo +nightly fmt --allcargo clippy