Skip to content

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jul 5, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

when metadata is non-existent in connector auth details, we need to fetch it from fixtures, it is not happening and this is causing havoc with Adyen.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

NIL

How did you test it?

Connector gets created on Adyen:

image

image

Checklist

  • I formatted the code prettier . --write
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 5, 2024
@pixincreate pixincreate added this to the July 2024 Release milestone Jul 5, 2024
@pixincreate pixincreate self-assigned this Jul 5, 2024
@pixincreate pixincreate requested review from a team as code owners July 5, 2024 08:21
@Gnanasundari24
Copy link
Contributor

@pixincreate Why few testcases are failing(Payout testcases).

@pixincreate
Copy link
Member Author

pixincreate commented Jul 5, 2024

@Gnanasundari24, below is the error message that we receive when Payout confirm is done manually:

{
    "error": {
        "type": "invalid_request",
        "message": "Payout 9d48c9ea-f99a-406f-90d5-7f2476d4559b cannot be updated for status requires_confirmation",
        "code": "IR_06"
    }
}

The reason being the support for manual confirmation has been removed with #4967 by @kashif-m. (It was originally removed by @srujanchikke in https://github.com/juspay/hyperswitch/pull/4941/files which was then closed for #4967)

Addressed in #5223

CC (for additional context): @Sakilmostak @srujanchikke

@likhinbopanna likhinbopanna enabled auto-merge July 5, 2024 18:04
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 91a9542 Jul 5, 2024
@likhinbopanna likhinbopanna deleted the fix-metadata-cypress branch July 5, 2024 19:18
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 5, 2024
pixincreate added a commit that referenced this pull request Jul 8, 2024
…ify-cypress

* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2024.07.08.0
  fix(connector): [adyen] remove browser info for mit and [paypal] add refund key in headers (#5225)
  chore(version): 2024.07.06.0
  feat(router): Pass the shipping email whenever the billing details are included in the session token response (#5228)
  fix(cypress): fix metadata missing while creating connector if not in auth (#5215)
  refactor: fix unit and documentation tests (#4754)
  feat(events): add hashed customer_email and feature_metadata (#5220)
  feat(events): Add payment metadata to hyperswitch-payment-intent-events (#5170)
  fix(analytics): using HashSet to represent the returned metrics (#5179)
  feat(core): billing_details inclusion in Payment Intent (#5090)
  feat(router): pass fields to indicate if the customer address details to be connector from wallets (#5210)
  fix(refunds): Add aliases on refund status for backwards compatibility (#5216)
  Feat(connector): [BRAINTREE] Implement Card Mandates (#5204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants